From owner-freebsd-current@FreeBSD.ORG Thu Jun 4 09:23:42 2015 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 470D8EFA; Thu, 4 Jun 2015 09:23:42 +0000 (UTC) (envelope-from jenkins-admin@freebsd.org) Received: from jenkins-9.freebsd.org (jenkins-9.freebsd.org [8.8.178.209]) by mx1.freebsd.org (Postfix) with ESMTP id 36A0C181A; Thu, 4 Jun 2015 09:23:42 +0000 (UTC) (envelope-from jenkins-admin@freebsd.org) Received: from jenkins-9.freebsd.org (localhost [127.0.0.1]) by jenkins-9.freebsd.org (Postfix) with ESMTP id C75BE12E9; Thu, 4 Jun 2015 09:23:41 +0000 (UTC) Date: Thu, 4 Jun 2015 09:23:39 +0000 (GMT) From: jenkins-admin@freebsd.org To: delphij@FreeBSD.org, bapt@FreeBSD.org, adrian@FreeBSD.org, jenkins-admin@FreeBSD.org, freebsd-current@FreeBSD.org, freebsd-i386@FreeBSD.org Message-ID: <427289270.25.1433409819998.JavaMail.jenkins@jenkins-9.freebsd.org> Subject: FreeBSD_HEAD_i386 - Build #235 - Failure MIME-Version: 1.0 X-Jenkins-Job: FreeBSD_HEAD_i386 X-Jenkins-Result: FAILURE Precedence: bulk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 09:23:42 -0000 FreeBSD_HEAD_i386 - Build #235 - Failure: Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD_i386/235/ to view the results. From owner-freebsd-current@FreeBSD.ORG Thu Jun 4 10:55:39 2015 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1FCCEE89 for ; Thu, 4 Jun 2015 10:55:38 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-la0-x22d.google.com (mail-la0-x22d.google.com [IPv6:2a00:1450:4010:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6749D1E7E for ; Thu, 4 Jun 2015 10:55:38 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: by laew7 with SMTP id w7so28956260lae.1 for ; Thu, 04 Jun 2015 03:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=PTCRXBcGrtJUMTj9rcmzIpYFiNI8vfKqH8N5xPa1IWw=; b=QQa9fEQ92n0PokLcfs3IFEXiKxWrKn21KaS2TXZAYv6oZXoOGKIdgS/v0vUbEzLpCE rzelGW0VjskWflSrYshF7SZOX0s2q3K4Wy27xve9pICVSwPQvqzmHrEKJuNQp5s+GnkR bM33qZFAnsp+ErsZAaEp5rXHnb2rvG7YBEY1Du/QcE1Faql6OXS/vtSQzhL/nc/pp0pI 9vdofFvpKOf8rOUMHUnchbGlElV87wpWKnmkF0ZnvHGaqSB19d6OYhHjvh2Hk865XXpS 0tm4HSZwYEpw/bRR8G63ajgejPr9d4neerW3hlJGzS2bXDUrffCmAGhDrqxxSAvOJhDt XXPg== X-Received: by 10.112.150.130 with SMTP id ui2mr36950899lbb.116.1433415336396; Thu, 04 Jun 2015 03:55:36 -0700 (PDT) Received: from omg (pluknet-1-pt.tunnel.tserv11.ams1.ipv6.he.net. [2001:470:1f14:4d0::2]) by mx.google.com with ESMTPSA id at2sm603728lbc.12.2015.06.04.03.55.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 03:55:35 -0700 (PDT) Sender: Sergey Kandaurov Date: Thu, 4 Jun 2015 13:55:32 +0300 From: Sergey Kandaurov To: current@freebsd.org Subject: [patch] chmod: change directory permissions in pre-order Message-ID: <20150604105532.GA3824@omg> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aM3YZ0Iwxop3KEKx" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 10:55:39 -0000 --aM3YZ0Iwxop3KEKx Content-Type: multipart/mixed; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Change directory permissions in pre-order. In this order, it won't try to recurse into a directory for which it doesn't have permission, before changing that permission. This follows the existing behavior in other BSDs, linux, OS X. Obtained from: NetBSD Found by: while digging in buildbot sources --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=p Content-Transfer-Encoding: quoted-printable Index: chmod.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- chmod.c (revision 283969) +++ chmod.c (working copy) @@ -162,14 +162,16 @@ atflag =3D AT_SYMLINK_NOFOLLOW; =20 switch (p->fts_info) { - case FTS_D: /* Change it at FTS_DP. */ + case FTS_D: if (!Rflag) fts_set(ftsp, p, FTS_SKIP); - continue; + break; case FTS_DNR: /* Warn, chmod. */ warnx("%s: %s", p->fts_path, strerror(p->fts_errno)); rval =3D 1; break; + case FTS_DP: /* Already changed at FTS_D. */ + continue; case FTS_ERR: /* Warn, continue. */ case FTS_NS: warnx("%s: %s", p->fts_path, strerror(p->fts_errno)); --FL5UXtIhxfXey3p5-- --aM3YZ0Iwxop3KEKx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVcC6kAAoJED9Ol7oQYHQZ/ZoIAIL43FtJ0fVANCzxXAfCAJwu hb9c1TedmMjbUUoFHbBP8JdU4eFC76Lt1eU2ObBrKHtjyi+N+hHK3QI1RGwIh7hp +4N4Sc3C3QOY9LzN204uPadFCujgB4VmENCSkvp/P8JHliZIaY+2vS90iVGbi3r+ hdP4eHMaiQkqdJUK/8D4ifyWNorClpETZJ0hekJmX47R0fAVTuKiEtHsqlk2f9o0 NnRsmMu6fB15JhguBk2YElOVZBq54E9gANH+w4lWIgdKsYRiWd/b3WrTu5es3CpA p8mq3Yt9xLt/m8xcOOodtRZ/Y91ItGmPIMfAXw1wTKZTywS1BDZbYZwBtiZxKw0= =jW7X -----END PGP SIGNATURE----- --aM3YZ0Iwxop3KEKx--