From owner-cvs-all Mon Feb 19 20:42:17 2001 Delivered-To: cvs-all@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 8AEA537B491; Mon, 19 Feb 2001 20:42:11 -0800 (PST) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f1K4g9W85880; Mon, 19 Feb 2001 21:42:09 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200102200442.f1K4g9W85880@harmony.village.org> To: Luigi Rizzo Subject: Re: cvs commit: src/sys/pci if_dc.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Mon, 19 Feb 2001 20:30:58 PST." <200102200430.f1K4UxW42792@iguana.aciri.org> References: <200102200430.f1K4UxW42792@iguana.aciri.org> Date: Mon, 19 Feb 2001 21:42:09 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200102200430.f1K4UxW42792@iguana.aciri.org> Luigi Rizzo writes: : sorry for missing that -- but i wonder, can't we just move : the test : : if ( (CSR_READ_4(sc, DC_ISR) & DC_INTRS) == 0) : return ; : : before the call to DC_LOCK and the assignment to ifp ? : We are just reading from the register here, and the only : possible race that i can think of is someone removing the : descriptor under our feed, which i presume cannot occur. : : The whole point of the above patch was avoid paying big cost : when we are called for no reason. Sure. We likely could. I know that the change worked. But the other change also seems to work, so I'll commit that now. Thanks for the suggestion. It occurred to me after I made the commit that maybe I should do that. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message