From nobody Mon Apr 8 21:08:10 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VD1ss2Ktfz5Fp0n for ; Mon, 8 Apr 2024 21:08:49 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VD1sr71ZRz4J54 for ; Mon, 8 Apr 2024 21:08:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712610529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ck9m2cSanRySvi6ff1rUglJbWjSgu7uhNIWH9C5peqU=; b=NJ/8/ulkKalEFz7VGqG95BGMdl1O8xSQJi3badZFNWiiIARkJkImxYHk7w/WbSZ6QsRRG6 /K3Cw/VUy+ce1XxHlriIuVlR531rJHpbwmbfM9yhqNSFsmzrDG4LB2p/6KL8M7PukXYI+e NjC+UCDdH7fLK+aLTbL46kflOPAIaAeS5LM8k0kUHYnPNDJpwr9Zx6VpJkiuKtd2LCPQac k6PXXYOgbfYtliNoYrIm8Rm4IfHOx9E5sVr2kFdwURVU6tqw2LVQQWBNe00fM8sO3d3p7F tbgAViVGXesiin8r9/yKeMBqmIRKtKLlYmePCWIEr/X2XLuLV3NplD0Sxe5NvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712610529; a=rsa-sha256; cv=none; b=KUZyhzcqH4JAu0R8odLY0gwZXLpdtSXrnqWTbUPL/HuU4iSr+C9/C5Dag6k1Oy3u+0a47d t1WLZydEIqtTFKXHm25hLtktZgcfkhXnDNF+uQWSCFO1kSzZnME4i3YyFdS7+AbQK8VQS8 GvzieKreLD4NKIC/FmJ2QIoseZoR2Ccs9bZdS8Mcz8PhUZPiG/tet4b8Q4SprIv2/V1Uqi Wx8dceGdlr0oIdhbichv956J68sSkJRd3PMLCEGKdBV82+ZRLeHAW3KxYGiuTrwjtYeF56 LMSTdosk4G6tgbEzJUvXelNkAs/g7s1qrp7nW2JocJFpjvAib6IjmDmFu3Lgaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712610529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ck9m2cSanRySvi6ff1rUglJbWjSgu7uhNIWH9C5peqU=; b=rdcRIaNjJtyI1xcUSLDCyTG5dFgHamufFrxXk+iFAuCPYavBptlNE46OPdNlSzpczmS0fj 9nq0is7G7HSOXDifeVzv7qeMDubDRUxGVebSv0X2Tz0El+42mwy3pL6dWKzzVjJ208sInC 3ln0hokwHGWkbzLBog9XrAu4Zc79iuPrTpLJO1EE4LNewysED5M7TUb55PCeU7J6FAC5Hx 04pz6Fg1lQwltHPiUoOtTvySTY6mOLmcNmzm8JlSsMivuX+KkUOgEBLaQLLTQahnCR4M6K rzmEGFtpXVzL1Mbxgx9mchVKa5FLi7BrpQnkm1BWKZXfHle8f30hkRsIzSBXTg== Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VD1sr6Q4yzY5G for ; Mon, 8 Apr 2024 21:08:48 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-56e2e09fc27so6692097a12.0 for ; Mon, 08 Apr 2024 14:08:48 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUlNSPx2iPsRCvr96PTpsGOzwznm/DqIzVAN9eKW80h1UrKQgcihFbYWeRPPkArocoKYEjxFMjTWSZvVzgQod/CAddNXsJnjBHVdiDmJcLSIZrk X-Gm-Message-State: AOJu0YzVrI4BAD3FUWTQwowT6LG6E8IRlQZKqWL6n/BFwjkmszQTxDnQ Aj+nVvRzs1MYfhDMyKiPTYbVLW0x0zOPdIIoJjn13IZDd3yuWgXqjQGXN6kMhxhL57kbDQjEj6U 3ndK7FXeRGWFLgCISdxDv8tzMKIXISle6nQga0A== X-Google-Smtp-Source: AGHT+IH7/bLXgQGLGHNKSLUPCJhRDQ2PogdoPX7MA2qb1HMdrLjsW/emXR9tE2gKWsCaMtpLuWlNCNUUrxHz0Zb3Cq8= X-Received: by 2002:a05:6402:e83:b0:56c:292f:84da with SMTP id h3-20020a0564020e8300b0056c292f84damr622823eda.17.1712610527449; Mon, 08 Apr 2024 14:08:47 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> <20240324202715.5d18838d@hal.tijl.coosemans.org> <20240331234553.1793b816@hal.tijl.coosemans.org> In-Reply-To: <20240331234553.1793b816@hal.tijl.coosemans.org> From: Po-Chuan Hsieh Date: Tue, 9 Apr 2024 05:08:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" To: =?UTF-8?Q?T=C4=B3l_Coosemans?= Cc: "Tobias C. Berner" , Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000020beb406159c362e" --00000000000020beb406159c362e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans wrote: > On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote: > > On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans wrote: > >> - You are using upstream distfiles that are quite large. The distfile= s > >> for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and > >> Serif add up to 234MB. These fonts will be installed by almost ever= y > >> user that uses FreeBSD as a desktop now that DejaVu appears to have > >> been abandoned. My proposal was to create our own distfiles and I > >> integrated that into makesum so the only extra step compared to a > >> normal version update was to upload the generated distfile to > >> freefall. I was willing to take over maintainership in case you > >> didn't want to deal with that. These distfiles add up to 27MB. And > >> if we put the extra weights (ExtraBold,...) and widths (Condensed,..= .) > >> in a separate port like you did it would be only 2MB. > > > > The committed one is my second version of noto fonts update. > > The previous version is to use the individual file from github.com just > > like those Noto CJK ports. > > I changed to upstream tarball because it's clearer/simpler and easier t= o > > track. > > I could change it back to the previous version for a smaller distfile > > footprint. > > Give me several days to clean up the Makefiles. > > Okay. > > >> - Some fonts have been split into x11-fonts/-basic providing Bol= d, > >> BoldItalic, Italic, and Regular, and x11-fonts/-extra providin= g > >> additional styles. Only some of these have x11-fonts/ as a > >> metaport currently. This needs to be made consistent. I think it > >> would be best to drop the metaports and move x11-fonts/-basic = to > >> x11-fonts/. That way pkg install installs the common > >> styles for all fonts. I think that this would be the most > >> intuitive/convenient. > >> (I was hoping to use subpackages for this instead of extra ports.) > > > > The -basic/-extra structure was kept for minimal change. > > I agree with you that it would be better to be consistent with all othe= r > > noto ports. > > I could merge the following ports: > > - noto-sans-basic/-extra > > - noto-sans-mono-basic/-extra > > - noto-sans-symbols-basic/-extra > > - noto-serif-basic/-extra > > However, what should be noto-basic's dependencies after the merge? > > It's okay to keep the -extra ports. What I meant was to rename the > -basic ports so noto-sans-basic becomes noto-sans for example. > I've prepared a patch [1] for the following changes: - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans - Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts/noto-sans-mono - Merge x11-fonts/noto-sans-symbols-{basic,extra} to x11-fonts/noto-sans-symbols - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif - Update x11-fonts/noto-basic to depend on the 4 merged ports - Update x11-fonts/noto-extra by removing the 4 -extra ports from RUN_DEPENDS [1] https://people.freebsd.org/~sunpoet/patch/noto.txt > >> - x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji b= ut > >> this isn't supported yet by graphics/cairo so emoji are broken now i= n > >> gtk applications. I think Ghostscript doesn't support it either. I= t > >> has to be removed again for now. > > > > It is handled in PR 278019 and > > ports 2878ca490586207c3cd7bb3ff94d1274f52013b0. > > Okay. > > >> - Besides Noto Color Emoji there's also the monochrome Noto Emoji that > >> can be useful in print. I think we should let x11-fonts/noto-emoji > >> install the monochrome font and move the existing x11-fonts/noto-emo= ji > >> to x11-fonts/noto-color-emoji so the names match. > > > > How about putting all emoji in the existing port (x11-fonts/noto-emoji)= ? > > That's up to you as maintainer. I would keep them apart because they > have different releases, version numbers and different upstreams. For > NotoEmoji there are also additional weights you could put in an -extra > port: > > NotoEmoji-Light.ttf (extra) > > https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW= uob_10jwvS-FGJCMY.ttf > NotoEmoji-Regular.ttf > > (basic) > > https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW= uob-r0jwvS-FGJCMY.ttf > NotoEmoji-Medium.ttf > > (extra) > > https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW= uob-Z0jwvS-FGJCMY.ttf > NotoEmoji-SemiBold.ttf > > (extra) > > https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW= uob911TwvS-FGJCMY.ttf > NotoEmoji-Bold.ttf > > (basic) > > https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGW= uob9M1TwvS-FGJCMY.ttf > --00000000000020beb406159c362e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T= =C4=B3l Coosemans <tijl@freebsd.org> wrote:
On Mon, 1 Apr 2024 04:17:09 +08= 00 Po-Chuan Hsieh wrote:
> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebsd.org> wro= te:
>> - You are using upstream distfiles that are quite large.=C2=A0 The= distfiles
>>=C2=A0 =C2=A0for the common (Latin, Greek, Cyrillic) fonts Sans, Sa= ns Mono, and
>>=C2=A0 =C2=A0Serif add up to 234MB.=C2=A0 These fonts will be insta= lled by almost every
>>=C2=A0 =C2=A0user that uses FreeBSD as a desktop now that DejaVu ap= pears to have
>>=C2=A0 =C2=A0been abandoned.=C2=A0 My proposal was to create our ow= n distfiles and I
>>=C2=A0 =C2=A0integrated that into makesum so the only extra step co= mpared to a
>>=C2=A0 =C2=A0normal version update was to upload the generated dist= file to
>>=C2=A0 =C2=A0freefall.=C2=A0 I was willing to take over maintainers= hip in case you
>>=C2=A0 =C2=A0didn't want to deal with that.=C2=A0 These distfil= es add up to 27MB.=C2=A0 And
>>=C2=A0 =C2=A0if we put the extra weights (ExtraBold,...) and widths= (Condensed,...)
>>=C2=A0 =C2=A0in a separate port like you did it would be only 2MB.= =C2=A0
>
> The committed one is my second version of noto fonts update.
> The previous version is to use the individual file from github.com just > like those Noto CJK ports.
> I changed to upstream tarball because it's clearer/simpler and eas= ier to
> track.
> I could change it back to the previous version for a smaller distfile<= br> > footprint.
> Give me several days to clean up the Makefiles.

Okay.

>> - Some fonts have been split into x11-fonts/<font>-basic pro= viding Bold,
>>=C2=A0 =C2=A0BoldItalic, Italic, and Regular, and x11-fonts/<fon= t>-extra providing
>>=C2=A0 =C2=A0additional styles.=C2=A0 Only some of these have x11-f= onts/<font> as a
>>=C2=A0 =C2=A0metaport currently.=C2=A0 This needs to be made consis= tent.=C2=A0 I think it
>>=C2=A0 =C2=A0would be best to drop the metaports and move x11-fonts= /<font>-basic to
>>=C2=A0 =C2=A0x11-fonts/<font>.=C2=A0 That way pkg install <= ;font> installs the common
>>=C2=A0 =C2=A0styles for all fonts.=C2=A0 I think that this would be= the most
>>=C2=A0 =C2=A0intuitive/convenient.
>>=C2=A0 =C2=A0(I was hoping to use subpackages for this instead of e= xtra ports.)
>
> The -basic/-extra structure was kept for minimal change.
> I agree with you that it would be better to be consistent with all oth= er
> noto ports.
> I could merge the following ports:
> - noto-sans-basic/-extra
> - noto-sans-mono-basic/-extra
> - noto-sans-symbols-basic/-extra
> - noto-serif-basic/-extra
> However, what should be noto-basic's dependencies after the merge?=

It's okay to keep the -extra ports.=C2=A0 What I meant was to rename th= e
-basic ports so noto-sans-basic becomes noto-sans for example.

I've prepared a patch [1] for the following cha= nges:
- Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto= -sans
- Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts= /noto-sans-mono
- Merge x11-fonts/noto-sans-symbols-{basic,extra}= to x11-fonts/noto-sans-symbols
- Merge x11-fonts/noto-serif-{bas= ic,extra} to x11-fonts/noto-serif
- Update=C2=A0x11-fonts/noto-ba= sic to depend on the 4 merged ports
- Update=C2=A0x11-fonts/noto-= extra by removing the 4 -extra ports from RUN_DEPENDS

<= div>[1]=C2=A0=C2=A0https://people.freebsd.org/~sunpoet/patch/noto.txt=


>> - x11/noto-emoji now installs the COLRv1 version of Noto Color Emo= ji but
>>=C2=A0 =C2=A0this isn't supported yet by graphics/cairo so emoj= i are broken now in
>>=C2=A0 =C2=A0gtk applications.=C2=A0 I think Ghostscript doesn'= t support it either.=C2=A0 It
>>=C2=A0 =C2=A0has to be removed again for now.
>
> It is handled in PR 278019 and
> ports 2878ca490586207c3cd7bb3ff94d1274f52013b0.

Okay.

>> - Besides Noto Color Emoji there's also the monochrome Noto Em= oji that
>>=C2=A0 =C2=A0can be useful in print.=C2=A0 I think we should let x1= 1-fonts/noto-emoji
>>=C2=A0 =C2=A0install the monochrome font and move the existing x11-= fonts/noto-emoji
>>=C2=A0 =C2=A0to x11-fonts/noto-color-emoji so the names match.
>
> How about putting all emoji in the existing port (x11-fonts/noto-emoji= )?

That's up to you as maintainer.=C2=A0 I would keep them apart because t= hey
have different releases, version numbers and different upstreams.=C2=A0 For=
NotoEmoji there are also additional weights you could put in an -extra
port:

NotoEmoji-Light.ttf (extra)
https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aW= jPDs-ar6uWaGWuob_10jwvS-FGJCMY.ttf
NotoEmoji-Regular.ttf (basic)
https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWj= PDs-ar6uWaGWuob-r0jwvS-FGJCMY.ttf
NotoEmoji-Medium.ttf (extra)
https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6a= WjPDs-ar6uWaGWuob-Z0jwvS-FGJCMY.ttf
NotoEmoji-SemiBold.ttf (extra)
https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPD= s-ar6uWaGWuob911TwvS-FGJCMY.ttf
NotoEmoji-Bold.ttf (basic)
https:= //fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob9M1Tw= vS-FGJCMY.ttf
--00000000000020beb406159c362e--