From owner-freebsd-hackers@freebsd.org Sun Jun 23 20:01:44 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2069F15D9631 for ; Sun, 23 Jun 2019 20:01:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CD546D56A for ; Sun, 23 Jun 2019 20:01:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id c11so8259883qkk.8 for ; Sun, 23 Jun 2019 13:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tGUWlbGnRQzV2uqgo21iDFxzV/lnAf0vMelhoEQQsAw=; b=Sg/FUpPLeFFF+cXXqrY409D1fcAFZo89BRqzoDhraKi6K7eIs7W9LruNKO6usq2L4K pNXjjJPDI+VxYJKjiioklteKi60Vbd+v3SUS44oCREkOPAV0+2KWoVNwZIjoltDA7wmJ uf2UGbAR7ImdKtR9ZCvmNvC/7px1Wq4fkpPQPWbUR5FaJyJGHVTnZHtAdmncF1AHQmNk QiFUfS8cVTVmoob3MhQsiMMsNYpWx31aXz9HoE51vYUA8sPtwpfUdKUGGs5YPEuFI1mB WvGnjXLZH93jcYEq62ISGTzXMSfiiTJJoEEgymM3//cAyXvMsWcwoX3gzMmPOjQOx8aM 9M+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tGUWlbGnRQzV2uqgo21iDFxzV/lnAf0vMelhoEQQsAw=; b=mth4k0L7WP4q+A7TaDaEywsX5vFj+qSWVqpxa3KZEnKZ7Pg0G2850rm+0PFp+5003i gzkDcC24CXVK5K1exd1NfpoyowJGMoZhE6DWpayN4J4AxlzJRIgvbC7mDRHshkde8Nqe zZYvq5bZBoDYDYKKKk4j1I5PaMdriAdrvoWlyg/GKTrb06UEuemg3jb7oImCjwNhzmJH pJf5Vni0m5M+wxAYZD/MyQMCzLWda2B1jpocZYUOVZzzGmb7qlImvdGaV0W6GauaJbrZ iNYYCsEjgjG1gdviM7JBKFCHR6U+3f4TsgjZ23VWSkr+U7R7CvBU200MCrWsME+ZS1Bo 2sYg== X-Gm-Message-State: APjAAAXzXnibaX9qihhjznfLq+jKQA8xiJowc/TJ4UmB3m5hNGrxRVnX vLk86Pp1cZZcLUa0hkk3XmRAWTk1sriK2r0RwQxZxA== X-Google-Smtp-Source: APXvYqyvkuNtvUunv0EL0CpWBFyt8SLzGOYU1wYoalC754F2pxBMZBp5GFGJ0uvinM/FjkodySICLvDvhd4otPaWT0E= X-Received: by 2002:a37:68ca:: with SMTP id d193mr108670126qkc.240.1561320102805; Sun, 23 Jun 2019 13:01:42 -0700 (PDT) MIME-Version: 1.0 References: <20190623191818.GA84365@raichu> <6B485E5C-9C8A-43C8-BD5A-528A74A61A23@FreeBSD.org> <79B7AEEE-7617-44D8-A16A-C8EC5F95455A@FreeBSD.org> In-Reply-To: <79B7AEEE-7617-44D8-A16A-C8EC5F95455A@FreeBSD.org> From: Warner Losh Date: Sun, 23 Jun 2019 14:01:31 -0600 Message-ID: Subject: Re: release notes file To: Glen Barber Cc: Mark Johnston , "freebsd-hackers@freebsd.org" , FreeBSD Release Engineering Team X-Rspamd-Queue-Id: 6CD546D56A X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Sg/FUpPL X-Spamd-Result: default: False [-5.98 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[4.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-3.00)[ip: (-9.48), ipnet: 2607:f8b0::/32(-3.14), asn: 15169(-2.33), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jun 2019 20:01:44 -0000 On Sun, Jun 23, 2019 at 1:56 PM Glen Barber wrote: > FWIW, I don=E2=80=99t think =E2=80=9Ceither/or=E2=80=9D is necessarily th= e best approach; meaning > I would like to still keep the tag in the default template. > A while ago, I proposed a protocol that we'd only have the RELNOTES file. The other part of the protocol was to remove it from RELNOTES once it was added to the release notes. This way, we can have multiple people working on the release notes should we be so fortunate to have those resources in the future. It's minorly racy, but not terrible. This way, release notes text could also be written by the committer and tweaked by whomever compiles the release notes. However, I'm cool with having it in the commit message + template since it's better to have a heads up you need to write something than not. The understanding would be a RelNotes: yes would mean that someone else would write the notes and if you wanted to have more control over what went out, you'd use RELNOTES. Glen, do you think that's a workable protocol? Warner > Glen > (Who knows first hand how much it sucks going through commit logs for > relnotes entries) > Sent from my phone. > Please excuse my brevity and/or typos. > > > On Jun 23, 2019, at 3:49 PM, Glen Barber wrote: > > > > Yes, please. > > > > Glen > > Sent from my phone. > > Please excuse my brevity and/or typos. > > > >> On Jun 23, 2019, at 3:18 PM, Mark Johnston wrote: > >> > >> Hi, > >> > >> Today we add a Relnotes tag to commits that warrant a release note. > >> My impression is that it doesn't work so well: if a committer forgets > >> or doesn't know to add one there's no way to amend the commit message > >> (same for MFCs), and a commit message isn't a convenient place to writ= e > >> the text of a release note. I would like to propose adding a top-leve= l > >> RELNOTES file instead, which like UPDATING would document notes for > >> specific commits. It would be truncated every time the head branch is > >> forked, and changes to it would be MFCed. This fixes the > >> above-mentioned problems and would hopefully reduce the amount of time > >> needed by re@ to compile release notes. > >> > >> For example: > >> > >> Index: RELNOTES > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- RELNOTES (nonexistent) > >> +++ RELNOTES (working copy) > >> @@ -0,0 +1,8 @@ > >> +Release notes for FreeBSD 13.0. > >> + > >> +r349286: > >> + swapon(8) can now erase a swap device immediately before > >> + enabling it, similar to newfs(8)'s -E option. This behaviour > >> + can be specified by adding -E to swapon(8)'s command-line > >> + parameters, or by adding the "trimonce" option to a swap > >> + device's /etc/fstab entry. > >> > >> What do folks think? > >> > > > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " >