From owner-freebsd-hackers@freebsd.org Sat Dec 22 01:39:06 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C5D5133C9C7 for ; Sat, 22 Dec 2018 01:39:06 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1DC78E695 for ; Sat, 22 Dec 2018 01:39:04 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AC01321F93 for ; Fri, 21 Dec 2018 20:39:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 21 Dec 2018 20:39:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h=to :from:subject:message-id:date:mime-version:content-type; s=fm3; bh=8u8U8p1Unp9SeUYU2Lgn8Dg0GKKvP2SyUost+bUv7Y4=; b=Y1hjuYnkWIul Ld5Qv77AZzTlXANelTC6P+AZvRyPkwJ7JqZhEffk46Z6ob7bhQVnmpNNmlHJju+z YGLU9a7en7dJ+cZPVrFx4bUtd+Wj2g5bG/M6YDozYACelRVY2Bm1w0pggARiY3cR u/8vrt+GEdHKuTzGNdFdKlnsuohOaTUxSJc8f+6g13+9Bl6e1T7Ep2Jx77zDJyUo /cf5bV6tKKl9/sHIKfsoCZLxd42vGc6AN0wtI8hIq/aDh9rlVVzTXGRenznmNCSX oSWC4XKygX89BReOnVGiqkxgJSfrHGXxSh1qH4S04ijITzjSOjKgZ/XybfSvLHgA BhVCWMXeew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=8u8U8p1Unp9SeUYU2Lgn8Dg0GKKvP 2SyUost+bUv7Y4=; b=EC9nS0O9dUx2DSfU/BlJf8beaFqmyNnRokzY+vFm3ESAa eynCFoBb2Xu+W8fCHRav9+OMfCcfzBELZ4isD6eS+9LGouYCkuioNsn5caFvd9AR 4Y8LuKyLnq9z4x2Q0ZXNKrGYykM5/iyDUAc8RJm6bQ2bzykDx+kTy8EIjHpzYYwT KYIH4CQ6f6abEeGJmgbOX9xZhVT8g3IKdX9HDQq7b/eRQ1uXKJjvv8L1UddDrfIT 3hNGUIffn1ez7XcYUfJlSIeoQaH2N4y7qiW/Rt3tSmVEquGfIyy4VpduQelNFuzo mC/IpaLpmrTUWAUm3z6kqW8rcJ2afNtWvzTVfhctQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejiedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecunecujfgurhepvffhuffkffgfgggtsehgtderofdtfeejnecuhfhrohhmpegjuh hrihcurfgrnhhkohhvuceohihurhhiphhvseihuhhrihhpvhdrnhgvtheqnecuffhomhgr ihhnpehfrhgvvggsshgurdhorhhgnecukfhppeelgedrvdeffedrvdefuddrudelheenuc frrghrrghmpehmrghilhhfrhhomhephihurhhiphhvseihuhhrihhpvhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from [192.168.1.2] (unknown [94.233.231.195]) by mail.messagingengine.com (Postfix) with ESMTPA id 073A7E4535 for ; Fri, 21 Dec 2018 20:39:01 -0500 (EST) To: freebsd-hackers From: Yuri Pankov Subject: is adding new private symbols to libc frowned upon? Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= mQENBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAG0H1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD6JAVQEEwEKAD4WIQT4arc+w94t Pi0v/3CTi+B/sSrhbAUCW7y7ogIbAwUJBaOagAULCQgHAwUVCgkICwUWAwIBAAIeAQIXgAAK CRCTi+B/sSrhbJ+ACACqOlkjZ+iP8K8hcwz/G6+c1lVkhuMWL+hxFeE149QuJAXQvkOj/UXO 7jY9HSqFbOYYY44/hujpQCu+/u2dsJ5MAA7TJspWK2zUxtFAzgDp1fRXmCvMlFLdI0yVkKOB JaK+HQP8rBT6yHzGw1KJ6VyOXuuD0Kx02Ou61qjG9/vPRR0jtaxog0rKxpf+yf0UvSM4vb7+ LdY2GQxgfcLcJ8hThR4ElWJAkDsG4CiXixGJuFJ+9dpMK6LHmP6M+NxV4NkzpNddn3Eii8XQ y5spxcLszp8csFBDtAC6BI9sHLhJ9Va1VKpuvSlDsBv4ZtsjnUCIaOiF5MDTYkddSPGGMBck uQENBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFScXACD sdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIolDahy 2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CANN8F 1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC0sE2 Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4zABEB AAGJATwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAKCRCT i+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuUD3kh 2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy+jsn TfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6Kv+V Ru54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2vZHBB 6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: Date: Sat, 22 Dec 2018 04:38:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5" X-Rspamd-Queue-Id: E1DC78E695 X-Spamd-Bar: -------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.net header.s=fm3 header.b=Y1hjuYnk; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=EC9nS0O9; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.net designates 66.111.4.25 as permitted sender) smtp.mailfrom=yuripv@yuripv.net X-Spamd-Result: default: False [-8.31 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.25]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; MX_GOOD(-0.01)[cached: in2-smtp.messagingengine.com]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[25.4.111.66.list.dnswl.org : 127.0.5.1]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[yuripv.net:s=fm3,messagingengine.com:s=fm1]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[yuripv.net]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-3.61)[ip: (-9.52), ipnet: 66.111.4.0/24(-4.67), asn: 11403(-3.78), country: US(-0.08)] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2018 01:39:06 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5 Content-Type: multipart/mixed; boundary="CoWJRoNTpJ1quOjP17OCk5IjGCqJB7m7E"; protected-headers="v1" From: Yuri Pankov To: freebsd-hackers Message-ID: Subject: is adding new private symbols to libc frowned upon? --CoWJRoNTpJ1quOjP17OCk5IjGCqJB7m7E Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Essentially, I need the __collate_equiv_value symbol to be visible to libregex for the changes in https://reviews.freebsd.org/D18531. Is the following change OK (it works, at least), or should try to avoid that? --- a/lib/libc/locale/Symbol.map +++ b/lib/libc/locale/Symbol.map @@ -212,6 +212,7 @@ FBSD_1.3 { FBSDprivate_1.0 { _PathLocale; __detect_path_locale; + __collate_equiv_value; __collate_load_error; __collate_range_cmp; }; --CoWJRoNTpJ1quOjP17OCk5IjGCqJB7m7E-- --EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwdlawACgkQk4vgf7Eq 4Wz1UwgAutD4hpHvWLBiFnJdFPmhaZk7GpSQqPD6npFuogpnBFiW++hSsUbsI5CY 7dRovng87sGLLA8UFG4bUJE1xKThF2/jUdjWJZsdCkq8LcgRPpTajPekGJ1ozH20 ZFP6vhLBRFYi3myHNmCfbGJIsIuGJF5aIwfqkyTD88mUCUyDIOzsr2vfW7W0+JjP 8DooEXckHU9UNGN5qAQlxHd2ePfpHN/qTHNd8KfjclDDpQuHsT4JlUvp7gMuj5m5 BjPki0X1voaVZg11RwE8m5/Uz7a/ty2n2LoVOUbtc1N4Z1xM80ILJt5z97O+/9Yp ezbJpblIIZuQX2DGro16Dt0e2yWIFw== =1qid -----END PGP SIGNATURE----- --EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5--