From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 26 02:44:42 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32CA11065672; Mon, 26 Apr 2010 02:44:42 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by mx1.freebsd.org (Postfix) with ESMTP id C3ABE8FC15; Mon, 26 Apr 2010 02:44:41 +0000 (UTC) Received: by qyk11 with SMTP id 11so14313396qyk.13 for ; Sun, 25 Apr 2010 19:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=cV2/V7swZCtqO/JsofX5VMnTLJG3nNAjIQ0uMf1xA1Q=; b=vZ7nZj0A6UqdWA+TNFsxsuxiwYVnrcRb2StJc4avm9sa1XNmCmZhtV1pNXgJDgGi6d Iv9CjBk2cYA5mh0UWg95CtUc62lhAP2qZcPqSHqMJaF78wyQJS0ECK+PbRg4RxOc9Iua t7j5tbXgSexKoupO9V+JDuiYaOOTwMg85GilE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hgqtnd5Czn3A1+g9KjAUxXlmJD/D2tV9+RMxQeSHTrm8ce37XBamv9ykwQDc8ORjQZ O+WIgD47KIP0RRCdIGF9Kcft6c/4IgXVlhBeEqbsXMf5B5YE1cWjYTSfuM8ZAjaqr6wL RDSde+keI+vz1ALO6tzrcaoVxZgkbXkQkIfjA= MIME-Version: 1.0 Received: by 10.229.232.198 with SMTP id jv6mr4112461qcb.11.1272249874985; Sun, 25 Apr 2010 19:44:34 -0700 (PDT) Received: by 10.229.233.11 with HTTP; Sun, 25 Apr 2010 19:44:34 -0700 (PDT) In-Reply-To: References: <4BCE5ECC.6070202@gmail.com> <4BCFE209.20501@FreeBSD.org> <20100422111758.GA39338@ei.bzerk.org> <4BD07F2D.3030809@FreeBSD.org> <4BD07FCB.4030604@FreeBSD.org> Date: Sun, 25 Apr 2010 19:44:34 -0700 Message-ID: From: Garrett Cooper To: Eitan Adler Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org, Ruben de Groot , Doug Barton , "Aryeh M. Friedman" , =?ISO-8859-1?Q?Trond_Endrest=F8l?= Subject: Re: regenerating /var/db/pkg X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 02:44:42 -0000 On Thu, Apr 22, 2010 at 10:05 AM, Eitan Adler wr= ote: > Same as before - if all is good I'll send a PR > > #!/bin/sh > # > # $FreeBSD: src/etc/periodic/daily/210.backup-aliases,v 1.6.36.1.2.1 > 2009/10/25 01:10:29 kensmith Exp $ > # > > # If there is a global system configuration file, suck it in. > # > if [ -r /etc/defaults/periodic.conf ] > then > =A0 =A0. /etc/defaults/periodic.conf > =A0 =A0source_periodic_confs > fi > > bak=3D/var/backups > db_loc=3D$(/usr/bin/make -f/usr/share/mk/bsd.port.mk -V PKG_DBDIR 2>/dev/= null) > bk_loc=3D"$bak/pkgdb.bak.tar.bz2" > > case "$daily_backup_pkgdb_enable" in > =A0 =A0[Yy][Ee][Ss]) This could be done via rc.subr's checkyesno function. > =A0 =A0 =A0 =A0if [ ! -d $db_loc ] Please quote the string. > =A0 =A0 =A0 =A0then > =A0 =A0 =A0 =A0 =A0 =A0echo '$daily_backup_pkgdb_enable is enabled but' \ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"$db_loc doesn't exist" > =A0 =A0 =A0 =A0 =A0 =A0rc=3D2 > =A0 =A0 =A0 =A0else > =A0 =A0 =A0 =A0 =A0 =A0rc=3D0 > > =A0 =A0 =A0 =A0 =A0 =A0echo "" > =A0 =A0 =A0 =A0 =A0 =A0echo "Backing up package db directory:" > > =A0 =A0 =A0 =A0 =A0 =A0[ -e $bk_loc ] && unlink $bk_loc Please quote. > =A0 =A0 =A0 =A0 =A0 =A0tar -cjf $bk_loc $db_loc || rc=3D3 Same here. > =A0 =A0 =A0 =A0fi;; > > =A0 =A0*) =A0rc=3D0;; > esac > > exit $rc Thanks, -Garrett