From owner-svn-src-all@freebsd.org Fri Mar 11 01:58:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAFF9ACB9BB for ; Fri, 11 Mar 2016 01:58:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4FF8812 for ; Fri, 11 Mar 2016 01:58:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id z76so128680384iof.3 for ; Thu, 10 Mar 2016 17:58:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=KRpyS46HbJ5wMazOzON5zYHt20Cbg9cCdemK1E/PB+Y=; b=pk9s+RvyjaZ1sd6zH19zu3TKX1x5BIEEakcvjQoHCheM3Ek9OY8gUYoe+NP+pTqtKW XkLFJKT8kZTJ2wtvI6C3/FNt78Gg0rv9DuOkTxfoI+rP7n+aHN/KHN6dCyEqeS2jDaJ9 cv7GGwrZ7h7Qkeuxfkk/GdVAY6ufYKflwcCr25C/mrNYk03rOQ5Hh2bvZkvnvFQdbnYo C48ue3KkEppWli4NrChPh+cjPqmzhBemGV7V3HavvtcyW1Z1xr3gMoE3zQeGwDqbiazo p5fm2LVSsskMNCv0wTx+gx5iW62rr+Rs7m6rZ6tgcxYyf3QE/2g9TtQcyx3tOSJLG9vS oSZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=KRpyS46HbJ5wMazOzON5zYHt20Cbg9cCdemK1E/PB+Y=; b=GOhQJ9SD8IzEzDgZIBGn+UcmMckl3+ggAkYpDdymD/d0fXxxdW02yHkAkUHZWs7TAX a+RD1VlthQ37tJV00P7ADr4ND6pzMBilG2LPmL8MRmCDflfHvNkDPqcJ+IsqreNs1ClI HHViao440QI4qWqXNrhZpZ1u2GbrrvruA/twcZ1SDnf0bciDfBdf4CTflWM1z39GkRXb V1tvZU2w1kFg0k/zZisYkkH1CK0tDdiXX9voc09v87/JB9bPxm2E8MOCxj+IcPdYGIP1 +bnO7siDm6hujiNwtwuUYz7k/pvlr4pvw8MTv9VbJI9gIKB+1EWz+NDHWlJj4JZKaUuC 6Ltg== X-Gm-Message-State: AD7BkJI+wVPai04TCn/d3SDpFvaVCHvrQYRAoj8186CcyrOwq/laiPvta1AYisqKAn0E8gpdubNwoRhj7uk4pA== MIME-Version: 1.0 X-Received: by 10.107.135.226 with SMTP id r95mr6618556ioi.59.1457661531688; Thu, 10 Mar 2016 17:58:51 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.36.65.230 with HTTP; Thu, 10 Mar 2016 17:58:50 -0800 (PST) X-Originating-IP: [2607:fb90:1908:151e:0:3d:6915:1701] Received: by 10.36.65.230 with HTTP; Thu, 10 Mar 2016 17:58:50 -0800 (PST) In-Reply-To: <56E1F72D.7000002@FreeBSD.org> References: <201603100033.u2A0X6uN027771@repo.freebsd.org> <56E1F72D.7000002@FreeBSD.org> Date: Thu, 10 Mar 2016 18:58:50 -0700 X-Google-Sender-Auth: 2DGlHHj_XPkNdGucvLrn7vtrT8s Message-ID: Subject: Re: svn commit: r296589 - head/sys/dev/fdc From: Warner Losh To: Bryan Drewery Cc: src-committers , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Warner Losh Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 01:58:53 -0000 On Mar 10, 2016 3:37 PM, "Bryan Drewery" wrote: > > On 3/9/16 4:33 PM, Warner Losh wrote: > > Author: imp > > Date: Thu Mar 10 00:33:06 2016 > > New Revision: 296589 > > URL: https://svnweb.freebsd.org/changeset/base/296589 > > > > Log: > > Stop assuming that bio_cmd is a bit field. > > > > Differential Revision: https://reviews.freebsd.org/D5587 > > > > Modified: > > head/sys/dev/fdc/fdc.c > > > > Modified: head/sys/dev/fdc/fdc.c > > ============================================================================== > > --- head/sys/dev/fdc/fdc.c Thu Mar 10 00:27:10 2016 (r296588) > > +++ head/sys/dev/fdc/fdc.c Thu Mar 10 00:33:06 2016 (r296589) > > @@ -941,7 +941,7 @@ fdc_worker(struct fdc_data *fdc) > > /* Disable ISADMA if we bailed while it was active */ > > if (fd != NULL && (fd->flags & FD_ISADMA)) { > > isa_dmadone( > > - bp->bio_cmd & BIO_READ ? ISADMA_READ : ISADMA_WRITE, > > + bp->bio_cmd == BIO_READ ? ISADMA_READ : ISADMA_WRITE, > > I think we should have some kind of file (like ports CHANGES) that lists > subtle KPI changes. This and the bio bzero change were easily missed > and could lead to who-knows-what downstream for vendors or even > out-of-tree modules. True. However, these have never been documented one way or another.... And this change isn't a change yet... I'd love a kpi change file. This is but one of many. We'd need someone clueful to watch the tree and remind people to add things to it. I'm also working on documenting our storage api so that people know better what is defined, vs what's there and subject to change. > Btw there are some missed still: > > ./dev/mfi/mfi.c: switch (bio->bio_cmd & 0x03) { > ./dev/mfi/mfi.c: switch (bio->bio_cmd & 0x03) { That makes me sad. Code like that has never been guaranteed. Bare constants.... shudder. Warner