From owner-cvs-sys Sun Apr 19 15:21:49 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA24929 for cvs-sys-outgoing; Sun, 19 Apr 1998 15:21:49 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from ifi.uio.no (0@ifi.uio.no [129.240.64.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA24848; Sun, 19 Apr 1998 22:21:26 GMT (envelope-from dag-erli@ifi.uio.no) Received: from hrotti.ifi.uio.no (2602@hrotti.ifi.uio.no [129.240.64.15]) by ifi.uio.no (8.8.8/8.8.7/ifi0.2) with ESMTP id AAA14285; Mon, 20 Apr 1998 00:21:13 +0200 (MET DST) Received: (from dag-erli@localhost) by hrotti.ifi.uio.no ; Mon, 20 Apr 1998 00:21:12 +0200 (MET DST) Mime-Version: 1.0 To: Bruce Evans Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c References: <199804190300.NAA15945@godzilla.zeta.org.au> Organization: Gutteklubben Terrasse / KRST / PUMS / YASMW X-url: http://www.stud.ifi.uio.no/~dag-erli/ X-Stop-Spam: http://www.cauce.org From: dag-erli@ifi.uio.no (Dag-Erling Coidan =?iso-8859-1?Q?Sm=F8rgrav?= ) Date: 20 Apr 1998 00:21:11 +0200 In-Reply-To: Bruce Evans's message of "Sun, 19 Apr 1998 13:00:06 +1000" Message-ID: Lines: 21 X-Mailer: Gnus v5.5/Emacs 19.34 Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans writes: > > Return EINVAL and do not change file pointer if resulting offset is negative. > > PR: kern/6184 > > This is wrong. Please back it out. It breaks at least the ability to > seek to high addresses in /dev/[k]mem on 64 bit systems. Not long ago Then IMHO we should do what IRIX does: forbid negative offsets for regular files, and allow it only for specific devices. But that would require delegating lseek to the device driver :( OK, I'm backing out vfs_syscalls.c and lseek.2. > I replied to the PR, but for some reason the followup didn't get attached > to the PR. If it's not a bug, shouldn't the PR have been closed with a "it's not a bug, it's a feature" comment? -- Nobody else has a .sig like this one.