From owner-svn-src-user@freebsd.org Sat Apr 20 16:15:58 2019 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65D09156BEA9 for ; Sat, 20 Apr 2019 16:15:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7DC0972C2; Sat, 20 Apr 2019 16:15:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x543.google.com with SMTP id z9so3938417pgu.10; Sat, 20 Apr 2019 09:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/HPFWCiBZeWNZEHQgT8jvHmx4CXuxcXeqraGeopVWGU=; b=TrDk3TVt/op8BRgVtQ/q5jMplmh7v/VAF23dqVyq3OHA4c3vtL/pWb2ygXof7zr8B6 ERY68JMmC/8J+GlljErybBvHb418VV+LncldW+XCLLH6fXKHV4Vo6eRoiwgklhgpSts+ ZTjPuF8MZRxmHDJ+WeZNVFv+IjFfIofiT/qnRCwKvLv2i/ooJvA6XJ17+50OVN6uRdFR BXIWazySgUGE/XtcxzwwoNsdvc/wnSA9uqg4bNg5V2uTTyzgPQEYRP8fnI/34npc2bg1 NyQhZboJ8sQuQ/SD2gWP3pS85Co1seIVG5wqRTvx2ytgEifqhehI7wpZUXPE1vwlqiQ9 Lvnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/HPFWCiBZeWNZEHQgT8jvHmx4CXuxcXeqraGeopVWGU=; b=a9KrV5p/2FuP6udwBfBc1b72astbXC2hVyIHVrn30d7ivqoifWUz2PDE8fexbXl5LN Nsg0hKVXOkR107Lvz9/IPtFHauF7FGuJbLCi0GBz6HVCFvykS/Uc98SU8izTf8Pd9Fhq wPJLz8L9xyo7sfWTYOGnnnqekhoQG6CzghDzWZ0K1wVJx4cnqwM0oAFTA/l8fpm97Zqq R3lKNsSZ8ffCyMqgAnqD5sMZ/fwi9cEr9+iSnr4O6sQJfrCOi/tQV22I9t1aiO2joYla kzQ4P3gRXuwaoBHl3HZj6W9A7LYK6cXiQDO+v33yZDyFzfpdTZIjo+/r1rLSeJxjDVH+ o06g== X-Gm-Message-State: APjAAAWm/+PaEAIR1HOcU8gS7Y5dqkBNOSf9nHAziJRb+cHia3f7hjfA uJhMFd3zXMaKZFJzk5zjaOLPKDZghEk= X-Google-Smtp-Source: APXvYqyWn5WsH13KLiqpAWV1JeVWkveL+cA2E5oD4nH9IWc6pdmZcJnYFpoXnPgCffzgd2WV8ednug== X-Received: by 2002:a62:480d:: with SMTP id v13mr10691526pfa.125.1555776956581; Sat, 20 Apr 2019 09:15:56 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id h189sm16447158pfc.125.2019.04.20.09.15.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2019 09:15:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r346449 - user/ngie/bug-237403/tests/sys/opencrypto From: Enji Cooper In-Reply-To: <201904201607.x3KG7m4A051487@repo.freebsd.org> Date: Sat, 20 Apr 2019 09:15:55 -0700 Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904201607.x3KG7m4A051487@repo.freebsd.org> To: Enji Cooper X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: D7DC0972C2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 16:15:58 -0000 > On Apr 20, 2019, at 9:07 AM, Enji Cooper wrote: >=20 > Author: ngie > Date: Sat Apr 20 16:07:47 2019 > New Revision: 346449 > URL: https://svnweb.freebsd.org/changeset/base/346449 >=20 > Log: > Replace `str.{decode,encode}("hex")` with binascii.(un)?hexlify >=20 > Encoding/decoding base_string objects as "hex" was removed in py3 and = replaced > with other methods, one being `binascii.(un)?hexlify`. I accidentally introduced other changes in this commit to cryptodev.py. = Summary is as follows: Py3 changed the default text encoding from ascii strings to Unicode = strings, which requires converting a number of code which working = previously with ascii to use byte (ascii binary, e.g., b=E2=80=99' = prefixed) strings. In order to convert between ascii binary and unicode = strings (which some of the dpkt/crypto APIs require), one must use the = .decode/.encode methods, as described in the Unicode guide: = https://docs.python.org/3/howto/unicode.html. This change introduces a work-in-progress item to use .decode/.encode in = cryptodev.py . It=E2=80=99s not 100% complete, so the tests fail when = converting objects to/from str/bytes objects, like shown below. Cheers, -Enji $ sudo kyua debug -k /usr/tests/sys/opencrypto/Kyuafile runtests:main = 2>&1 | less =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ERROR: test_gcm (__main__.GenTestCase..GendCryptoTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/tests/sys/opencrypto/cryptotest.py", line 77, in test_gcm self.runGCM(i, 'ENCRYPT') File "/usr/tests/sys/opencrypto/cryptotest.py", line 126, in runGCM rct, rtag =3D c.encrypt(pt, iv, aad) File "/usr/tests/sys/opencrypto/cryptodev.py", line 305, in encrypt iv) File "/usr/tests/sys/opencrypto/cryptodev.py", line 232, in _doaead s =3D array.array('B', src.encode("ascii")) AttributeError: 'bytes' object has no attribute =E2=80=98encode' ... =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D ERROR: test_gcm (__main__.GenTestCase..GendCryptoTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/tests/sys/opencrypto/cryptotest.py", line 77, in test_gcm self.runGCM(i, 'ENCRYPT') File "/usr/tests/sys/opencrypto/cryptotest.py", line 126, in runGCM rct, rtag =3D c.encrypt(pt, iv, aad) File "/usr/tests/sys/opencrypto/cryptodev.py", line 305, in encrypt iv) File "/usr/tests/sys/opencrypto/cryptodev.py", line 232, in _doaead s =3D array.array('B', src.encode("ascii")) AttributeError: 'bytes' object has no attribute 'encode'