From owner-freebsd-current@FreeBSD.ORG Thu May 27 00:59:33 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE56C106566C for ; Thu, 27 May 2010 00:59:33 +0000 (UTC) (envelope-from lobo@bsd.com.br) Received: from mail-gx0-f224.google.com (mail-gx0-f224.google.com [209.85.217.224]) by mx1.freebsd.org (Postfix) with ESMTP id 4AE3D8FC0A for ; Thu, 27 May 2010 00:59:33 +0000 (UTC) Received: by gxk24 with SMTP id 24so3904974gxk.3 for ; Wed, 26 May 2010 17:59:32 -0700 (PDT) Received: by 10.150.183.11 with SMTP id g11mr126555ybf.66.1274921972241; Wed, 26 May 2010 17:59:32 -0700 (PDT) Received: from papi.localnet ([189.70.227.237]) by mx.google.com with ESMTPS id u2sm5371454ybh.15.2010.05.26.17.59.29 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 May 2010 17:59:31 -0700 (PDT) From: Mario Lobo To: freebsd-current@freebsd.org, current@freebsd.org Date: Wed, 26 May 2010 21:59:27 +0000 User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.5; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005262159.27350.lobo@bsd.com.br> Cc: Subject: Re: SUJ Changes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2010 00:59:33 -0000 On Wednesday 26 May 2010 23:56:24 Garrett Cooper wrote: > On Wed, May 26, 2010 at 3:52 PM, Marcelo/Porks wrote: > > On 5/25/10, Marcelo/Porks wrote: > >> Hi! I tested the r208241 and it's seems to be ok but this calls my > >> atention to other thing: Could I disable de SU when the SUJ is > >> enabled? > >> > >> I did some tests and seems that I can do this (logs bellow). > >> > >> But will SUJ work properly with SU disabled? > > > > Hi guys. I'm not sure if I could call this a problem but I can disable > > SU when SUJ is enabled, so SUJ will remain enabled and SU will be > > disabled. > > > > #tunefs -j enable /dev/device > > #tunefs -n disable /dev/device > > > > I did a patch for sbin/tunefs/tunefs.c that disable SUJ when the user > > disable SU. Maybe this will be useful for some of you. > > > > Thanks. > > > > > > Index: sbin/tunefs/tunefs.c > > =================================================================== > > --- sbin/tunefs/tunefs.c (revision 208580) > > +++ sbin/tunefs/tunefs.c (working copy) > > @@ -460,6 +460,14 @@ > > if ((~sblock.fs_flags & FS_DOSOFTDEP) == > > FS_DOSOFTDEP) warnx("%s remains unchanged as disabled", name); else { > > + /* also disable SUJ */ > > + if ((sblock.fs_flags & FS_SUJ) == FS_SUJ) > > { + warnx("soft updates journaling > > will be disabled too"); > > + journal_clear(); > > + sblock.fs_flags &= ~FS_SUJ; > > + sblock.fs_sujfree = 0; > > + warnx("remove .sujournal to > > reclaim space"); > > + } > > sblock.fs_flags &= ~FS_DOSOFTDEP; > > warnx("%s cleared", name); > > } > > I think that it makes sense to have this as a force option as someone > may want to retain their journal instead of disposing of it > automatically. > > I think that the 2nd warnx should be the first warnx, and the 2nd > warnx can be removed as it'll be quickly followed up by > cleared. Changing `remove' to `removing' and changing `.sujournal' to > journal would a) make the action more correct and b) make the concept > more straightforward as to what's being removed, as Jeff or someone > else may decide to remove or rename .sujournal in the future, and it's > just another thing that users don't have to understand that aren't > familiar with FreeBSD or SUJ. > > Thanks, > -Garrett > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > Is this available in 8-STABLE? Can it be? Can this be activated on my current installation without loosing data? Thanks, -- Mario Lobo http://www.mallavoodoo.com.br FreeBSD since 2.2.8 [not Pro-Audio.... YET!!] (99% winfoes FREE)