From owner-svn-src-all@freebsd.org Fri May 27 03:04:57 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61611B4BBE1; Fri, 27 May 2016 03:04:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qg0-x232.google.com (mail-qg0-x232.google.com [IPv6:2607:f8b0:400d:c04::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 041F4189B; Fri, 27 May 2016 03:04:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qg0-x232.google.com with SMTP id q32so45736134qgq.3; Thu, 26 May 2016 20:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=UVSYh5lK8m1cFCAinMNL2Worsg0tH1K9ZJUhuUq6kPI=; b=VQ4dbKl+ReQF2m67/PFzF4+ElIdCBNFlYOXzsdc/qPZv6LG2Fun5XDcmdfLTugVXjF Qq9zRkTWE324FPcXksoKqWRa6AkWZUZ7OIOrPmo+qXrt5hUhTLgB2yYZgnquvqlQKzVn KH7hxGkzLstX7Ho4VgLlQm4kFSuozbVqQmPzu+lWApt9N3CyrNxflGG6vDb49WShdXG1 ASya77wzxgL9NfhXJXhOTgX+USHqXWSN8p/7Fk+liBcCEtveno90rRarfeRL2RtXGTKv gtjKYQYgdvY4dHUe4f1O3kSVbJFevjWgpIMYnK4FmH0LGWX3dl69EV6ldR8xOtyN3vxT a33Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=UVSYh5lK8m1cFCAinMNL2Worsg0tH1K9ZJUhuUq6kPI=; b=KulrzEoZcbntP5P+CKRQymKfXnu/vow06E591hP52eo2ZOPIjGFVbHVB5YLhIZPzHx iep3VkrtfL8gHF8YWCwmPYVEOGAp24OjegUP6cORjTqHscOr93DaIXeUtLXj3fQlDzF+ pMe9yAX9bVXXnpW0JLnzR3OOMiY11wBG6s1ZN1OzYxSS5T1gheTlWqFB5TkE2LwmB54B Cf7Lj0srjslwNdiv0IXGBkkULCcaQZixg7NQkZzIVaNaVyioFJurZ0XW446HmSKPWJin RGc37DZUvXtHjEkniAxeBuvEUQ0zcsAIkDAPLscQJsZeUebWqy9s3PKULShJ5IA71IAi NDYw== X-Gm-Message-State: ALyK8tL5Bfg+SXKmQ0t9ZPBQGfKpcZT48vogCMEXrLt+AmAitMrOtOJLrSeeeJ3QxFskel64/ek92yACpGhk+g== MIME-Version: 1.0 X-Received: by 10.140.153.135 with SMTP id 129mr11940389qhz.71.1464318296210; Thu, 26 May 2016 20:04:56 -0700 (PDT) Received: by 10.55.170.146 with HTTP; Thu, 26 May 2016 20:04:56 -0700 (PDT) In-Reply-To: <0f2c3d10-d2dd-3f76-982f-91fbeeb5f3db@freebsd.org> References: <201605261929.u4QJTTV5085421@repo.freebsd.org> <0f2c3d10-d2dd-3f76-982f-91fbeeb5f3db@freebsd.org> Date: Thu, 26 May 2016 20:04:56 -0700 Message-ID: Subject: Re: svn commit: r300773 - in head/sys: crypto crypto/aesni crypto/sha2 crypto/siphash kern sys From: Ngie Cooper To: Allan Jude Cc: "Conrad E. Meyer" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , "gjb >> Glen Barber" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 03:04:57 -0000 On Thu, May 26, 2016 at 7:35 PM, Allan Jude wrote: > On 2016-05-26 15:29, Conrad E. Meyer wrote: >> Author: cem >> Date: Thu May 26 19:29:29 2016 >> New Revision: 300773 >> URL: https://svnweb.freebsd.org/changeset/base/300773 >> >> Log: >> crypto routines: Hint minimum buffer sizes to the compiler >> >> Use the C99 'static' keyword to hint to the compiler IVs and output digest >> sizes. The keyword informs the compiler of the minimum valid size for a given >> array. Obviously not every pointer can be validated (i.e., the compiler can >> produce false negative but not false positive reports). >> >> No functional change. No ABI change. >> >> Sponsored by: EMC / Isilon Storage Division ... > This seems to have broken on sparc64, and other gcc based arches: > > ===> lib/libc (obj,all,install) > In file included from /usr/src/lib/libc/../libmd/md5.h:40, > from /usr/src/lib/libc/../libmd/md5c.c:42: > /usr/obj/sparc64.sparc64/usr/src/tmp/usr/include/sys/md5.h:47: > error: static or type qualifiers in abstract declarator > --- md5c.o --- > *** [md5c.o] Error code 1 I was wondering about that in the original commit. It might be a good idea to revert both commits and reintroduce them with another keyword (i.e. __static, or something in sys/cdefs.h ) Thanks, -Ngie