From owner-freebsd-smp Sat Nov 7 19:28:37 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA20522 for freebsd-smp-outgoing; Sat, 7 Nov 1998 19:28:37 -0800 (PST) (envelope-from owner-freebsd-smp@FreeBSD.ORG) Received: from spinner.netplex.com.au (spinner.netplex.com.au [202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA20511; Sat, 7 Nov 1998 19:28:28 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.9.1/8.9.1/Spinner) with ESMTP id LAA22362; Sun, 8 Nov 1998 11:25:49 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199811080325.LAA22362@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: Bruce Evans cc: jc@irbs.com, mike@smith.net.au, current@FreeBSD.ORG, smp@FreeBSD.ORG Subject: Re: Dog Sloooow SMP In-reply-to: Your message of "Sun, 08 Nov 1998 13:43:52 +1100." <199811080243.NAA32642@godzilla.zeta.org.au> Date: Sun, 08 Nov 1998 11:25:48 +0800 From: Peter Wemm Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Bruce Evans wrote: > >No idea. I've received verification that fixing this for all 686-class > >CPUs seems to work (ie. it's OK on the Cyrix MII and doesn't appear to > >impact performance there), so the tests are now generalised for the > >entire 686-class. > > It's only OK for MII's because of various `#if 0's and `#ifdef SMP's > that prevent non-OK code from running on MII's. I think it should be CPU specific, not cpu class specific. The model-specific-registers are very specific to the Intel family. I'd be a lot happier if it was 'if (cpu == CPU_686 || cpu == CPU_PII) ...' Of course, feature tests would be better. 'if (cpu_features & CF_PPRO_MSR)...' The problem is that there is a 'cpu_feature' already for the CPUID. We need more general flags than what Intel choose to tell us. > Bruce Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message