From owner-cvs-all@FreeBSD.ORG  Sat Nov  8 00:55:39 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 12FE516A4CE; Sat,  8 Nov 2003 00:55:39 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3E36B43FAF; Sat,  8 Nov 2003 00:55:36 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id TAA24037;
	Sat, 8 Nov 2003 19:55:32 +1100
Date: Sat, 8 Nov 2003 19:55:31 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Ruslan Ermilov <ru@freebsd.org>
In-Reply-To: <20031107160744.GA47423@sunbay.com>
Message-ID: <20031108194726.M674@gamplex.bde.org>
References: <200311070330.hA73UWPR092624@repoman.freebsd.org>
	<200311070327.hA73RWjs092423@repoman.freebsd.org>
	<20031107084045.GD86943@sunbay.com>
	<20031107160744.GA47423@sunbay.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Alexander Kabaev <kan@freebsd.org>
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: Bruce Evans <bde@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/contrib/gcc c-lex.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2003 08:55:39 -0000

On Fri, 7 Nov 2003, Ruslan Ermilov wrote:

> On Sat, Nov 08, 2003 at 02:36:09AM +1100, Bruce Evans wrote:
> > On Fri, 7 Nov 2003, Ruslan Ermilov wrote:
> >
> > > On Thu, Nov 06, 2003 at 07:09:40PM -0800, Alexander Kabaev wrote:
> > > > kan         2003/11/06 19:09:40 PST
> > > >
> > > >   FreeBSD src repository
> > > >
> > > >   Modified files:
> > > >     contrib/gcc          c-lex.c
> > > >   Log:
> > > >   Drop the revision 1.2 (don't let gcc(1) hide warnings in system headers)
> > > >   and use stock version of this file now.
> > > >   ...
> > >
> > > Will -Wsystem-headers from bsd.sys.mk for WARNS > 0 still take care
> > > of emitting warnings in system headers?
> >
> > If WARNS > 0 it will :-).  I think we have enough WARNS > 0 to catch
> > most problems, but developers, especially bde and ru, should run with
> > -Wsystem-headers unconditional in bsd.sys.mk.
> >
> I mean, does -Wsystem-headers affect both cc(1) and cpp(1) now?

Yes, but I think your question is whether we enable it for cpp.  We don't
do anything except enable it in CFLAGS if WARNS > 0 AFAIK, so only
invocations of cpp that use CFLAGS get it.  This may be enough.

Bruce