From owner-dev-commits-src-main@freebsd.org Wed May 19 13:42:13 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE5F5642BEF; Wed, 19 May 2021 13:42:13 +0000 (UTC) (envelope-from jclarke@marcuscom.com) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [IPv6:2607:fc50:1:f300::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.marcuscom.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FlYvT3WTVz4lv0; Wed, 19 May 2021 13:42:12 +0000 (UTC) (envelope-from jclarke@marcuscom.com) Received: from [10.116.79.227] ([173.38.117.71]) (authenticated bits=0) by creme-brulee.marcuscom.com (8.16.1/8.16.1) with ESMTPSA id 14JDg5Hp080695 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Wed, 19 May 2021 09:42:05 -0400 (EDT) (envelope-from jclarke@marcuscom.com) X-Authentication-Warning: creme-brulee.marcuscom.com: Host [173.38.117.71] claimed to be [10.116.79.227] Subject: Re: git: 3d846e48227e - main - Do not forward datagrams originated by link-local addresses To: Lutz Donnerhacke , Zhenlei Huang Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202105182101.14IL1Gki054229@gitrepo.freebsd.org> <20210519055407.GA9715@belenus.iks-jena.de> From: Joe Clarke Message-ID: <10b475c5-0100-2567-4e92-73b168b97e3f@marcuscom.com> Date: Wed, 19 May 2021 09:42:00 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210519055407.GA9715@belenus.iks-jena.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.5 required=5.0 tests=NICE_REPLY_A,RDNS_NONE autolearn=disabled version=3.4.5 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on creme-brulee.marcuscom.com X-Rspamd-Queue-Id: 4FlYvT3WTVz4lv0 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_RCPT(0.00)[]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 13:42:13 -0000 On 5/19/21 01:54, Lutz Donnerhacke wrote: > On Tue, May 18, 2021 at 07:51:38PM -0400, Joe Clarke wrote: >> Just out of curiosity, why remove the RFC reference from the comment? > > May you please include the author of the change for such questions? > >>> commit 3d846e48227e2e78c1e7b35145f57353ffda56ba >>> Author: Zhenlei Huang >>> AuthorDate: 2021-05-18 20:51:37 +0000 >>> Commit: Lutz Donnerhacke >>> CommitDate: 2021-05-18 20:59:46 +0000 >>> >>> The current implement of ip_input() reject packets destined for >>> 169.254.0.0/16, but not those original from 169.254.0.0/16 link-local >>> addresses. >>> >>> Fix to fully respect RFC 3927 section 2.7. >>> >>> PR: 255388 >>> Reviewed by: donner, rgrimes, karels >>> MFC after: 1 month >>> Differential Revision: https://reviews.freebsd.org/D29968 > > I did only commit this differential, but set a month for MFC, exactly to > have to opportunity to fix such mistakes. > IMHO, I'd like to see the RFC reference remain. I see rgrimes response that the RFC's can change with errata and bis docs, but the anchor still provides additional context that one can use to learn more about why this code exists, and they can chase any future forward references. It was there in the initial code, and the commit message saw fit to reference it again. Removing it just seems like lost context. Joe -- PGP Key : http://www.marcuscom.com/pgp.asc