From owner-p4-projects@FreeBSD.ORG Mon Aug 14 08:51:06 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4104816A4E5; Mon, 14 Aug 2006 08:51:06 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CE1C16A4E1 for ; Mon, 14 Aug 2006 08:51:06 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0924643D67 for ; Mon, 14 Aug 2006 08:50:57 +0000 (GMT) (envelope-from gonzo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7E8ovaX052645 for ; Mon, 14 Aug 2006 08:50:57 GMT (envelope-from gonzo@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7E8ovoN052642 for perforce@freebsd.org; Mon, 14 Aug 2006 08:50:57 GMT (envelope-from gonzo@FreeBSD.org) Date: Mon, 14 Aug 2006 08:50:57 GMT Message-Id: <200608140850.k7E8ovoN052642@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to gonzo@FreeBSD.org using -f From: Oleksandr Tymoshenko To: Perforce Change Reviews Cc: Subject: PERFORCE change 103819 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2006 08:51:06 -0000 http://perforce.freebsd.org/chv.cgi?CH=103819 Change 103819 by gonzo@gonzo_hq on 2006/08/14 08:50:21 o Make threads' stack aligned to 8 bytes. It's required by EABI for proper handling of 64-bits arguments in va_args. Affected files ... .. //depot/projects/mips2/src/sys/mips/mips/vm_machdep.c#7 edit Differences ... ==== //depot/projects/mips2/src/sys/mips/mips/vm_machdep.c#7 (text+ko) ==== @@ -188,10 +188,11 @@ * Enable interrupts and unmask timer interrupt (HW IRQ5) */ td->td_pcb->pcb_regs[PCB_REG_SR] = MIPS_SR_INT_IE | - (((1 << 5) << 8) << 2); + (((1 << 5) << 8) << 2); - /* Stack pointer. */ - td->td_pcb->pcb_regs[PCB_REG_SP] = (register_t)_ALIGN(td->td_frame - 1); + /* Stack pointer. Should be double-word aligned due to EABI */ + td->td_pcb->pcb_regs[PCB_REG_SP] = + (register_t)((uint32_t)(td->td_frame - 1) & ~7); } void