From nobody Mon Sep 11 19:21:30 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RkxRh2bjWz4sgfH for ; Mon, 11 Sep 2023 19:22:08 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RkxRh1ypNz3d3j for ; Mon, 11 Sep 2023 19:22:08 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694460128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mh9D6W6N2CjX5+8BBlvcqTvTBK/cNgKYr1lF5Y0Sxvw=; b=mxDa/fzprGqIRsV39goPyuGfa3shHxPctlsd7lZqqT9Zx6a0S3ISpQd0GeD1dIr60et3m4 1lZpMbUiOARnrY57pSoG7BYNL1plh5HJnoG7FnWyqLMr/bqsTyD915kY4XnwZ/FQ9hoEx/ Olr32/pxjHDYPRAI5CZCUUTt1c1OoHVKsCLRO0p7aC3s+we2grgAsrjSbECifIMVqtdzB9 wk729ssQfahMJbbaV41PmYJCvxAtHIJlYrb3Ao3seLUhuxdbSlN1NDGbwuXXoR/NsiNp1L hZI0Izg1KXuzrbx8ligJP4COdtW8nzrHBUpCaEE69AfauxyeyU+xrdqiluqgAA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694460128; a=rsa-sha256; cv=none; b=PlRx3BvrZG2shu50yORm5Qr5lhv6lheMydSpJFJddPTlqxzvLKuRp9HBGq7pEyl3c3vIo2 O5dYhbArJ4D++XAnzuiJk/hknvks7Y/kl7198UOviuwjEdn8YebVnUMSf63puoLvyYVkpQ t6X064IH1RHdL7gvwypDwlNa01eHSRgaRltBDl7yOn5jywzycZaRvbxBhksLEAed/qRZtL UUAB9hIR7AxPpZuwi9GtO06CXqnxFD+JndRWW/48s4Lo5g7vXf/ag6qGbTjB3kCJWqtdH1 33D6je35SKXzNUaQOaoC6RzKvKgkDQCsYyvj0hbv6ooa2NAl7WuttFdXBWAntg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694460128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mh9D6W6N2CjX5+8BBlvcqTvTBK/cNgKYr1lF5Y0Sxvw=; b=Vzelf8+6fWksgxMFXHX80/pWFx1HKYOPNrklbSD+uztJTJxzit1XT/0rp4eeayCR32tCz5 QkkOq2RQiqOP5kpJz03ZpQOFgAyl44I1h+mgFHUdXl4td1/+XPOPiXGOgB/M4lYMFEwy0D ZHrYNjf7gmfFvI5OU5extKRwYgwRbOU0NkCEiqyLHskVlqY0nOiKDg9NHj2wd4j5kf5IL9 DoG4P5zD31D/rkOZpI9vtg6mGCgFTPECQT2F42nOC7wUz5rXIo/cENOGjNJJ2u7M2NJdvY reamBn1dAD8RXgzcT7n+GT07vWubiGfs3Cjal9cuVsIIvDf3J8SUGy8ubfX0UA== Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RkxRh0rFMz18Rx for ; Mon, 11 Sep 2023 19:22:08 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-52f33659d09so2734570a12.1 for ; Mon, 11 Sep 2023 12:22:08 -0700 (PDT) X-Gm-Message-State: AOJu0YwaWNuj2fSYFlQ+QG1TWe8qHZlmoq6PzoAoYwldQFCK/JcCpUxw JznPdZCZvpzqsywIbvUkD/kp2HV1ASiGn8VAo4gNTA== X-Google-Smtp-Source: AGHT+IFiaQ7T6JBFN3k1NNUsqVNkluSYurz2vA44e4ekrwh9yzA0j7LrQAzBee0hig7vgnR+9MPkdSf5QtGX9kGxpx8= X-Received: by 2002:aa7:d0cf:0:b0:52e:585a:e95 with SMTP id u15-20020aa7d0cf000000b0052e585a0e95mr7650170edo.2.1694460126835; Mon, 11 Sep 2023 12:22:06 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202307220748.36M7mgIt016872@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 12 Sep 2023 03:21:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7bb64b89d0e5 - main - framework: add Mk/Uses/pycryptography To: Antoine Brodin , "Tobias C. Berner" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f252ec06051a3da2" --000000000000f252ec06051a3da2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, On Tue, Aug 1, 2023 at 2:31=E2=80=AFAM Po-Chuan Hsieh = wrote: > Hello, > > How about USE_PYTHON=3D{cryptography_build,cryptography,cryptography_test= }? > USE_PYTHON=3Dcryptography is the runtime dependency because it is mostly > used in RUN_DEPENDS. > > For the current ports tree, I get the following result via "git grep > pycryptography": > 89 USES=3Dpycryptography:run > 5 USES=3Dpycryptography:test > 2 USES=3Dpycryptography:run,test > 1 USES=3Dpycryptography:build,run > 0 USES=3Dpycryptography > > I've submitted PR 273727 for this. Thanks. Regards, sunpoet > Regards, > sunpoet > > On Mon, Jul 24, 2023 at 10:54=E2=80=AFPM Tobias C. Berner > wrote: > >> Moin moin >> >> It seemed an easier way to stop-gap fix this issue separately. But >> you're probably right, that python.mk would be the preferred location >> to do so. >> >> I can move it there. >> >> >> mfg Tobias >> >> On Sat, 22 Jul 2023 at 14:51, Antoine Brodin wrote= : >> > >> > On Sat, Jul 22, 2023 at 7:48=E2=80=AFAM Tobias C. Berner >> wrote: >> > > >> > > The branch main has been updated by tcberner: >> > > >> > > URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D7bb64b89d0e5ec8d77b28f834126= 9ffbad279ebf >> > > >> > > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf >> > > Author: Tobias C. Berner >> > > AuthorDate: 2023-07-22 06:16:46 +0000 >> > > Commit: Tobias C. Berner >> > > CommitDate: 2023-07-22 07:46:38 +0000 >> > > >> > > framework: add Mk/Uses/pycryptography >> > > >> > > With the added new DEFAULT_VERSION >> "PYCRYPTOGRAHY_DEFAULT=3Drust|legacy" >> > > it is important to transparently depend on the right one. >> > > >> > > This is the job of this new uses. >> > > >> > > So instead of manually adding dependency lines like >> > > >> > > >> RUN_DEPENDS=3D${PYTHON_PKGNAMEPREFIX}cryptography>0:security/py-cryptog= raphy@ >> ${PY_FLAVOR} >> > > >> > > this should now be >> > > >> > > USES=3Dpycryptography:run >> > > >> > > Supported arguments: ,build,run,test >> > > If no argument is given, it defaults to 'build,run'. >> > > >> > > A future commit will update to security/py-cryptography will >> introduce a >> > > rust dependency. >> > > >> > > PR: 254853 >> > >> > Hi, >> > >> > Why isn't it a USE_PYTHON=3D pycryptography? >> > >> > Antoine >> > --000000000000f252ec06051a3da2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

On Tue, Aug 1, 2023 a= t 2:31=E2=80=AFAM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
Hello,=

How about USE_PYTHON=3D{cryptography_build,crypto= graphy,cryptography_test}?
USE_PYTHON=3Dcryptography is the runti= me dependency because it is mostly used in RUN_DEPENDS.

For the current ports tree, I get the following result via "git = grep pycryptography":
89 USES=3Dpycryptography:run
=C2=A05 USES=3Dpycryptography:test
=C2=A02 USES=3Dpycryptography= :run,test
=C2=A01 USES=3Dpycryptography:build,run
=C2= =A00 USES=3Dpycryptography


=
I've submitted PR=C2=A0273727 for this.
Thanks.

Regards,
sunpoet

= =C2=A0
Regards,
sunpoet

On = Mon, Jul 24, 2023 at 10:54=E2=80=AFPM Tobias C. Berner <tcberner@freebsd.org> wrot= e:
Moin moin

It seemed an easier way to stop-gap fix this issue separately. But
you're probably right, that python.mk would be the preferred location
to do so.

I can move it there.


mfg Tobias

On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <antoine@freebsd.org> wrote:
>
> On Sat, Jul 22, 2023 at 7:48=E2=80=AFAM Tobias C. Berner <tcberner@freebsd.org= > wrote:
> >
> > The branch main has been updated by tcberner:
> >
> > URL: h= ttps://cgit.FreeBSD.org/ports/commit/?id=3D7bb64b89d0e5ec8d77b28f8341269ffb= ad279ebf
> >
> > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
> > Author:=C2=A0 =C2=A0 =C2=A0Tobias C. Berner <tcberner@FreeBSD.= org>
> > AuthorDate: 2023-07-22 06:16:46 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Tobias C. Berner <tcberner@FreeBSD.= org>
> > CommitDate: 2023-07-22 07:46:38 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0framework: add Mk/Uses/pycryptography
> >
> >=C2=A0 =C2=A0 =C2=A0With the added new DEFAULT_VERSION "PYCRY= PTOGRAHY_DEFAULT=3Drust|legacy"
> >=C2=A0 =C2=A0 =C2=A0it is important to transparently depend on the= right one.
> >
> >=C2=A0 =C2=A0 =C2=A0This is the job of this new uses.
> >
> >=C2=A0 =C2=A0 =C2=A0So instead of manually adding dependency lines= like
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RUN_DEPENDS=3D${PY= THON_PKGNAMEPREFIX}cryptography>0:security/py-cryptography@${PY_FLAVOR}<= br> > >
> >=C2=A0 =C2=A0 =C2=A0this should now be
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0USES=3Dpycryptogra= phy:run
> >
> >=C2=A0 =C2=A0 =C2=A0Supported arguments: <none>,build,run,te= st
> >=C2=A0 =C2=A0 =C2=A0If no argument is given, it defaults to 'b= uild,run'.
> >
> >=C2=A0 =C2=A0 =C2=A0A future commit will update to security/py-cry= ptography will introduce a
> >=C2=A0 =C2=A0 =C2=A0rust dependency.
> >
> >=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0254853
>
> Hi,
>
> Why isn't it a USE_PYTHON=3D pycryptography?
>
> Antoine
--000000000000f252ec06051a3da2--