From owner-freebsd-ports@FreeBSD.ORG Sun Aug 31 09:50:12 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2AC14BEB for ; Sun, 31 Aug 2014 09:50:12 +0000 (UTC) Received: from hapkido.dreamhost.com (hapkido.dreamhost.com [66.33.216.122]) by mx1.freebsd.org (Postfix) with ESMTP id 0A04A1FCB for ; Sun, 31 Aug 2014 09:50:11 +0000 (UTC) Received: from homiemail-a6.g.dreamhost.com (homie.mail.dreamhost.com [208.97.132.208]) by hapkido.dreamhost.com (Postfix) with ESMTP id 366FC9214D for ; Sun, 31 Aug 2014 02:50:04 -0700 (PDT) Received: from homiemail-a6.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a6.g.dreamhost.com (Postfix) with ESMTP id 1F6BD59806C for ; Sun, 31 Aug 2014 02:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=dylanleigh.net; h=date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=dylanleigh.net; bh=hNfnSovPtfsTiTeH4ZoUGe3yOMk=; b=vU/XQ2BvqD/J0GP+okE+7ytacx3SWeyJ4tqKiQvLszPMsjld8eS5l0WHohsFp 0ywELul/cVtsPvX+1dBBnQvSQ7uqtZAInNNq3AjkA7oCRZG+tq4c/n7OPEzDHHy5 YRMP4W1AHF/hCmbyqMb6l7vtCCUuF4Xk8VMPN0nIZYAJ3s= Received: from exhan.dylanleigh.net (ppp118-209-111-31.lns20.mel4.internode.on.net [118.209.111.31]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: dleigh@htns.net) by homiemail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 8C36459806B for ; Sun, 31 Aug 2014 02:49:52 -0700 (PDT) Date: Sun, 31 Aug 2014 19:49:30 +1000 From: Dylan Leigh To: freebsd-ports@freebsd.org Subject: Patch with issues for amanda-server/amanda-client Message-ID: <20140831094930.GA31615@exhan.dylanleigh.net> References: <20140831091814.A861C704071@homiemail-a5.g.dreamhost.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140831091814.A861C704071@homiemail-a5.g.dreamhost.com> X-Author-WWW: http://www.dylanleigh.net User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2014 09:50:12 -0000 I've filed a patch to amanda-server (and slave port amanda-client) to add staging support and set me as maintainer: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193196 This is my first staging patch; I followed all the steps in the wiki guide at https://wiki.freebsd.org/ports/StageDir but have a few unresolved issues because the way the port is built: 1) Amanda (upstream code) builds its own install-hook target which it uses to set setuid bits amongst other things, This isn't ideal and prevents packages being built as non-root. I have tried to fix this but haven't had the time yet to figure it out so I have set NEEDS_ROOT in the Makefile for now. 2) Many reported orphans were added to the plist after several iterations of the patch, and I am not sure if I have set everything correctly so that files which will only be present given certain OPTIONS are set correctly in the plist and vice versa. Some of the reported orphans seem to be false positives (see (3)) 3) The way the whole Amanda port is split into a master -server and a slave -client seems to be causing a lot of the complications In particular, the master -server port actually depends on the slave -client port being built. The -server port contains all the code for building the client including a seperate plist and a big chunk of the Makefile. It might solve some of the complication if the seperation between the two was ripped out with one port for both with a CLIENT_ONLY option (as the server requires the client files installed anyway). Please let me know if you have any advice/criticism/suggestions/hints/ opinions/there is anything missing. Thanks, Dylan -- Dylan Leigh // VU# s4081906 // www.dylanleigh.net