Date: Wed, 2 Dec 2009 09:08:48 -0700 From: Scott Long <scottl@samsco.org> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: scsi@FreeBSD.org Subject: Re: cd(4) M_WAITOK allocations with periph lock held Message-ID: <060A52A1-CFD0-4866-AD23-A1B47A2E79B5@samsco.org> In-Reply-To: <20091202135919.GA3675@a91-153-117-195.elisa-laajakaista.fi> References: <20091201180524.GB7961@a91-153-117-195.elisa-laajakaista.fi> <20091201142930.I99667@pooker.samsco.org> <20091202135919.GA3675@a91-153-117-195.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
Done, thanks! Scott On Dec 2, 2009, at 6:59 AM, Jaakko Heinonen wrote: > > Hi, > > On 2009-12-01, Scott Long wrote: >> How about the attached match instead. It refactors the code so that >> unlocks aren't needed. > > Looks OK to me. Some nits below. > >> bailout: >> + xpt_release_ccb(ccb); >> + cam_periph_unlock(periph); >> + > > The file seems to have an empty line after labels in other places. > Maybe > put one here too. > >> bailout: >> >> + xpt_release_ccb(ccb); >> + cam_periph_unlock(periph); > > You can remove the now unused "bailout:" label from cdsendkey(). > > Do you want to commit it? > > Thanks. > -- > Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?060A52A1-CFD0-4866-AD23-A1B47A2E79B5>