From owner-svn-src-all@freebsd.org Sat Nov 4 06:04:21 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9687DE66180; Sat, 4 Nov 2017 06:04:21 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B9C826E7; Sat, 4 Nov 2017 06:04:21 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from Xins-MBP.ut.rhv.delphij.net (unknown [IPv6:2601:646:8882:37a:11a7:9b92:f2ee:fbfb]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id D48CE26A21; Fri, 3 Nov 2017 23:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1509775460; x=1509789860; bh=IvmAUgFJRdYFScEiqGWglUFQciI3R2vggLsA6L8OLZE=; h=Cc:Subject:To:References:From:Date:In-Reply-To; b=fQy6c/5Qh8vxrxMvOmCzPTy1lHsLs0jcYaxxG4L2tt5HXq10ym5krNt13Rk54DkWs EAPqPBi12Vi3DljloRr5Xedq3Jk/To3glI2/w6nQr+q9GlRyA33/C8Cf5tPtDKeoQi ixURT5BcUdRufkEVhM2DOMisGRzOaYaix++JG/34= Cc: d@delphij.net, Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r325378 - head/sys/dev/ipmi To: Warner Losh References: <201711040301.vA431wdY002757@repo.freebsd.org> <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> From: Xin Li Message-ID: <04d2ee66-d19d-3aff-a30a-c87045fc884a@delphij.net> Date: Fri, 3 Nov 2017 23:04:17 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 06:04:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO Content-Type: multipart/mixed; boundary="Nlf6FHllnGhXjapGNR1TRkS8idLeOiHhR"; protected-headers="v1" From: Xin Li To: Warner Losh Cc: d@delphij.net, Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: <04d2ee66-d19d-3aff-a30a-c87045fc884a@delphij.net> Subject: Re: svn commit: r325378 - head/sys/dev/ipmi References: <201711040301.vA431wdY002757@repo.freebsd.org> <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> In-Reply-To: --Nlf6FHllnGhXjapGNR1TRkS8idLeOiHhR Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/3/17 22:53, Warner Losh wrote: >=20 >=20 > On Fri, Nov 3, 2017 at 11:29 PM, Xin Li > wrote: >=20 >=20 >=20 > On 11/3/17 20:01, Warner Losh wrote: > > Author: imp > > Date: Sat Nov=C2=A0 4 03:01:58 2017 > > New Revision: 325378 > > URL: https://svnweb.freebsd.org/changeset/base/325378 > > > > > Log: > >=C2=A0 =C2=A0Make the startup timeout 0 seconds by default rathern= than 420s.=C2=A0 This > >=C2=A0 =C2=A0makes the default fail safe when watchdogd is disable= d (which is also > >=C2=A0 =C2=A0the default). >=20 > I'm not sure if this is good: what if watchdogd is enabled, but the= > system get stuck before watchdogd starts? >=20 >=20 > Correct. This feature has to be opt-in on top of watchdogd. If you don'= t > add-in this feature, you won't have this new protection. You have to se= t > hw.ipmi.wd_startup_countdown to activate it. >=20 > More complicated logic may be possible, but the ipmi driver has no clue= > if watchdogd is enabled, so I'm not sure I see a path forward to > automatically doing the right thing with sensible defaults. Have I > overlooked something? No you didn't. I missed the fact that hw.ipmi.wd_startup_countdown can be set in loader. Sorry for the noise. Cheers, --Nlf6FHllnGhXjapGNR1TRkS8idLeOiHhR-- --iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZ/VhkAAoJEJW2GBstM+nslVIQAJGJ21WP/KyHT3kh0sgrQtc0 D6B6aD646VK0MwzoLpk4xx6NxMoB0ninNKil8IZIm/h4seex3ZV0HPu/VEJj+7dS cTZsK8ojh2hoAsvQYW2BHYX8VeT6fI+84N8wKNIa/1IN+8EMjMvINzlgDFMHDiQE VmTnw5TaPn/KbUlP8XrmktFZ+YzzYT9U7wFcGBkriCSicGidr+aVtzyujajS3JdY i8Fu0sssS1BzFmEV1zxzQjrI0eiPuxpXL/9J1+KawFMt7Y/SZ13m4wa3p2JAMHn6 J+eE5Fa38He20RcDSPaXfFXlowyDigBSI+qFdlQSd87BQiDD9FL79aS5Wv0Hi2Y9 17L+/iiB7hI5RSl3KIJM0FmaJRq3Iel9biMrj2cjYFc3uauv0YvQeTZnRCjQ04JY HSJQRSgxSef2OCCWMLtPIDW1u4RMdUeVuHNATWwCkWxZ7gdpthLiL0RadeR7yubx /N9ahnygJ4XEmQ0Tfx1LPmLt3CwUP6tBznYmoF412AmNa44gkHD+bNtrCoPRVzxP BF/QuHigAOsXu5sPPqhrawnpyKL9mVLwdS3o+AeADCORKfoay6yuLRXM7SOIh2JH g2DYHQir3faBJ/y+ShVFDF/LiKlqxfMaaCSSRuNQVlWbpQrBEdb83M0uXF2Te7qB /3RnlYNPHhakp/0V6yjd =o/uD -----END PGP SIGNATURE----- --iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO--