From owner-freebsd-hackers@FreeBSD.ORG  Mon Jul 19 09:37:44 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF9C516A4CE; Mon, 19 Jul 2004 09:37:43 +0000 (GMT)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3E5D443D58; Mon, 19 Jul 2004 09:37:43 +0000 (GMT)
	(envelope-from glebius@freebsd.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.12.11/8.12.8) with ESMTP id i6J9bWZr048480
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 19 Jul 2004 13:37:33 +0400 (MSD)
	(envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.12.11/8.12.11/Submit) id i6J9bWbU048479;
	Mon, 19 Jul 2004 13:37:32 +0400 (MSD)
	(envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@freebsd.org using -f
Date: Mon, 19 Jul 2004 13:37:32 +0400
From: Gleb Smirnoff <glebius@freebsd.org>
To: Julian Elischer <julian@elischer.org>
Message-ID: <20040719093732.GA48459@cell.sick.ru>
References: <Pine.NEB.3.96L.1040719003147.37108w-100000@fledge.watson.org>
	<40FB533D.2080208@elischer.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <40FB533D.2080208@elischer.org>
User-Agent: Mutt/1.5.6i
cc: hackers@freebsd.org
cc: Robert Watson <rwatson@freebsd.org>
Subject: Re: linker_load_module(NULL, "modname", ...) from thread with no
	user	process
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jul 2004 09:37:44 -0000

On Sun, Jul 18, 2004 at 09:51:09PM -0700, Julian Elischer wrote:
J> Probably the onl thing to do is to refuse to try an load the modules if 
J> you are not running
J> in the context of a process..

What about adding this check to ng_make_node()? It works for me OK.

                if (curthread->td_ithd != NULL)
                        return(EAGAIN);

Or even to linker_load_module()?

And possibly EAGAIN is not the best choice.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE