Date: Wed, 9 Nov 2005 21:55:10 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Attila Nagy <bra@fsn.hu> Cc: freebsd-hackers@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: Reproduceable freeze with quotas enabled Message-ID: <20051109215200.M33260@fledge.watson.org> In-Reply-To: <437064D6.6060504@fsn.hu> References: <436A868F.4010606@fsn.hu> <20051104095129.M9692@fledge.watson.org> <436B8918.9060105@fsn.hu> <436C7998.5040404@fsn.hu> <437064D6.6060504@fsn.hu>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1698448597-1131573310=:33260 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Tue, 8 Nov 2005, Attila Nagy wrote: > Any chance to investigate it further? It's a really annoying bug, which > makes quota support a little bit useless. Attached is a patch that corrects at least one or two deadlock scenarios in UNIX domain socket garbage collecting (unpgc_task.diff). I've also attached a patch for kern_descriptor.c that fixes a bug there in the passing of file descriptors referencing files over UNIX domain sockets (closef_threadnull.diff). I've committed the latter to 7.x, with the intent to merge to 6.x in a week or so. The larger UNIX domain socket garbage collection patch I need to think about some more, but I'm quite interested in whether it fixes the deadlock you're seeing (or for that matter, makes it worse somehow). Thanks, Robert N M Watson --0-1698448597-1131573310=:33260 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=unpgc_task.diff Content-Transfer-Encoding: BASE64 Content-ID: <20051109215510.Y33260@fledge.watson.org> Content-Description: Content-Disposition: attachment; filename=unpgc_task.diff SW5kZXg6IHVpcGNfdXNycmVxLmMNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N ClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9zeXMva2Vybi91aXBjX3VzcnJl cS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNTgNCmRpZmYgLXUgLXIx LjE1OCB1aXBjX3VzcnJlcS5jDQotLS0gdWlwY191c3JyZXEuYwkzMSBPY3Qg MjAwNSAxNTo0MToyNSAtMDAwMAkxLjE1OA0KKysrIHVpcGNfdXNycmVxLmMJ OSBOb3YgMjAwNSAyMTo0OTo1MyAtMDAwMA0KQEAgLTU5LDYgKzU5LDcgQEAN CiAjaW5jbHVkZSA8c3lzL3N4Lmg+DQogI2luY2x1ZGUgPHN5cy9zeXNjdGwu aD4NCiAjaW5jbHVkZSA8c3lzL3N5c3RtLmg+DQorI2luY2x1ZGUgPHN5cy90 YXNrcXVldWUuaD4NCiAjaW5jbHVkZSA8c3lzL3VuLmg+DQogI2luY2x1ZGUg PHN5cy91bnBjYi5oPg0KICNpbmNsdWRlIDxzeXMvdm5vZGUuaD4NCkBAIC0x MTIsNiArMTEzLDEzIEBADQogI2RlZmluZQlVTlBfTE9DS19BU1NFUlQoKQlt dHhfYXNzZXJ0KCZ1bnBfbXR4LCBNQV9PV05FRCkNCiAjZGVmaW5lCVVOUF9V TkxPQ0tfQVNTRVJUKCkJbXR4X2Fzc2VydCgmdW5wX210eCwgTUFfTk9UT1dO RUQpDQogDQorLyoNCisgKiBHYXJiYWdlIGNvbGxlY3Rpb24gb2YgY3ljbGlj IGZpbGUgZGVzY3JpcHRvci9zb2NrZXQgcmVmZXJlbmNlcyBvY2N1cnMNCisg KiBhc3luY2hyb25vdXNseSBpbiBhIHRhc2txdWV1ZSBjb250ZXh0LiAgU2Vl IHVucF9nYygpIGZvciBhIGZ1bGwNCisgKiBkZXNjcmlwdGlvbi4NCisgKi8N CitzdGF0aWMgc3RydWN0IHRhc2sJdW5wX2djX3Rhc2s7DQorDQogc3RhdGlj IGludCAgICAgdW5wX2F0dGFjaChzdHJ1Y3Qgc29ja2V0ICopOw0KIHN0YXRp YyB2b2lkICAgIHVucF9kZXRhY2goc3RydWN0IHVucGNiICopOw0KIHN0YXRp YyBpbnQgICAgIHVucF9iaW5kKHN0cnVjdCB1bnBjYiAqLHN0cnVjdCBzb2Nr YWRkciAqLCBzdHJ1Y3QgdGhyZWFkICopOw0KQEAgLTEyMCw3ICsxMjgsNyBA QA0KIHN0YXRpYyB2b2lkICAgIHVucF9kaXNjb25uZWN0KHN0cnVjdCB1bnBj YiAqKTsNCiBzdGF0aWMgdm9pZCAgICB1bnBfc2h1dGRvd24oc3RydWN0IHVu cGNiICopOw0KIHN0YXRpYyB2b2lkICAgIHVucF9kcm9wKHN0cnVjdCB1bnBj YiAqLCBpbnQpOw0KLXN0YXRpYyB2b2lkICAgIHVucF9nYyh2b2lkKTsNCitz dGF0aWMgdm9pZCAgICB1bnBfZ2MoX191bnVzZWQgdm9pZCAqLCBpbnQpOw0K IHN0YXRpYyB2b2lkICAgIHVucF9zY2FuKHN0cnVjdCBtYnVmICosIHZvaWQg KCopKHN0cnVjdCBmaWxlICopKTsNCiBzdGF0aWMgdm9pZCAgICB1bnBfbWFy ayhzdHJ1Y3QgZmlsZSAqKTsNCiBzdGF0aWMgdm9pZCAgICB1bnBfZGlzY2Fy ZChzdHJ1Y3QgZmlsZSAqKTsNCkBAIC03OTUsMTkgKzgwMyw5IEBADQogCX0N CiAJc29pc2Rpc2Nvbm5lY3RlZCh1bnAtPnVucF9zb2NrZXQpOw0KIAl1bnAt PnVucF9zb2NrZXQtPnNvX3BjYiA9IE5VTEw7DQotCWlmICh1bnBfcmlnaHRz KSB7DQotCQkvKg0KLQkJICogTm9ybWFsbHkgdGhlIHJlY2VpdmUgYnVmZmVy IGlzIGZsdXNoZWQgbGF0ZXIsDQotCQkgKiBpbiBzb2ZyZWUsIGJ1dCBpZiBv dXIgcmVjZWl2ZSBidWZmZXIgaG9sZHMgcmVmZXJlbmNlcw0KLQkJICogdG8g ZGVzY3JpcHRvcnMgdGhhdCBhcmUgbm93IGdhcmJhZ2UsIHdlIHdpbGwgZGlz cG9zZQ0KLQkJICogb2YgdGhvc2UgZGVzY3JpcHRvciByZWZlcmVuY2VzIGFm dGVyIHRoZSBnYXJiYWdlIGNvbGxlY3Rvcg0KLQkJICogZ2V0cyB0aGVtIChy ZXN1bHRpbmcgaW4gYSAicGFuaWM6IGNsb3NlZjogY291bnQgPCAwIikuDQot CQkgKi8NCi0JCXNvcmZsdXNoKHVucC0+dW5wX3NvY2tldCk7DQotCQl1bnBf Z2MoKTsJLyogV2lsbCB1bmxvY2sgVU5QLiAqLw0KLQl9IGVsc2UNCi0JCVVO UF9VTkxPQ0soKTsNCi0JVU5QX1VOTE9DS19BU1NFUlQoKTsNCisJaWYgKHVu cF9yaWdodHMpDQorCQl0YXNrcXVldWVfZW5xdWV1ZSh0YXNrcXVldWVfdGhy ZWFkLCAmdW5wX2djX3Rhc2spOw0KKwlVTlBfVU5MT0NLKCk7DQogCWlmICh1 bnAtPnVucF9hZGRyICE9IE5VTEwpDQogCQlGUkVFKHVucC0+dW5wX2FkZHIs IE1fU09OQU1FKTsNCiAJdW1hX3pmcmVlKHVucF96b25lLCB1bnApOw0KQEAg LTEzOTUsNyArMTM5Myw3IEBADQogCXVtYV96b25lX3NldF9tYXgodW5wX3pv bmUsIG5tYmNsdXN0ZXJzKTsNCiAJTElTVF9JTklUKCZ1bnBfZGhlYWQpOw0K IAlMSVNUX0lOSVQoJnVucF9zaGVhZCk7DQotDQorCVRBU0tfSU5JVCgmdW5w X2djX3Rhc2ssIDAsIHVucF9nYywgTlVMTCk7DQogCVVOUF9MT0NLX0lOSVQo KTsNCiB9DQogDQpAQCAtMTU4MSwxNCArMTU3OSwyMCBAQA0KIH0NCiANCiAv Kg0KLSAqIHVucF9kZWZlciBpcyB0aHJlYWQtbG9jYWwgZHVyaW5nIGdhcmJh Z2UgY29sbGVjdGlvbiwgYW5kIGRvZXMgbm90IHJlcXVpcmUNCi0gKiBleHBs aWNpdCBzeW5jaHJvbml6YXRpb24uICB1bnBfZ2NpbmcgcHJldmVudHMgb3Ro ZXIgdGhyZWFkcyBmcm9tIGVudGVyaW5nDQotICogZ2FyYmFnZSBjb2xsZWN0 aW9uLCBhbmQgcGVyaGFwcyBzaG91bGQgYmUgYW4gc3ggbG9jayBpbnN0ZWFk Lg0KKyAqIHVucF9kZWZlciBpbmRpY2F0ZXMgd2hldGhlciBhZGRpdGlvbmFs IHdvcmsgaGFzIGJlZW4gZGVmZXJlZCBmb3IgYSBmdXR1cmUNCisgKiBwYXNz IHRocm91Z2ggdW5wX2djKCkuICBJdCBpcyB0aHJlYWQgbG9jYWwgYW5kIGRv ZXMgbm90IHJlcXVpcmUgZXhwbGljaXQNCisgKiBzeW5jaHJvbml6YXRpb24u DQogICovDQotc3RhdGljIGludAl1bnBfZGVmZXIsIHVucF9nY2luZzsNCitz dGF0aWMgaW50CXVucF9kZWZlcjsNCisNCitzdGF0aWMgaW50IHVucF90YXNr Y291bnQ7DQorU1lTQ1RMX0lOVChfbmV0X2xvY2FsLCBPSURfQVVUTywgdGFz a2NvdW50LCBDVExGTEFHX1JELCAmdW5wX3Rhc2tjb3VudCwgMCwgIiIpOw0K Kw0KK3N0YXRpYyBpbnQgdW5wX3JlY3ljbGVkOw0KK1NZU0NUTF9JTlQoX25l dF9sb2NhbCwgT0lEX0FVVE8sIHJlY3ljbGVkLCBDVExGTEFHX1JELCAmdW5w X3JlY3ljbGVkLCAwLCAiIik7DQogDQogc3RhdGljIHZvaWQNCi11bnBfZ2Mo dm9pZCkNCit1bnBfZ2MoX191bnVzZWQgdm9pZCAqYXJnLCBpbnQgcGVuZGlu ZykNCiB7DQogCXN0cnVjdCBmaWxlICpmcCwgKm5leHRmcDsNCiAJc3RydWN0 IHNvY2tldCAqc287DQpAQCAtMTU5NywxNSArMTYwMSw4IEBADQogCWludCBu ZmlsZXNfc25hcDsNCiAJaW50IG5maWxlc19zbGFjayA9IDIwOw0KIA0KLQlV TlBfTE9DS19BU1NFUlQoKTsNCi0NCi0JaWYgKHVucF9nY2luZykgew0KLQkJ VU5QX1VOTE9DSygpOw0KLQkJcmV0dXJuOw0KLQl9DQotCXVucF9nY2luZyA9 IDE7DQorCXVucF90YXNrY291bnQrKzsNCiAJdW5wX2RlZmVyID0gMDsNCi0J VU5QX1VOTE9DSygpOw0KIAkvKg0KIAkgKiBiZWZvcmUgZ29pbmcgdGhyb3Vn aCBhbGwgdGhpcywgc2V0IGFsbCBGRHMgdG8NCiAJICogYmUgTk9UIGRlZmVy ZWQgYW5kIE5PVCBleHRlcm5hbGx5IGFjY2Vzc2libGUNCkBAIC0xNzAwLDYg KzE2OTcsOSBAQA0KIAl9IHdoaWxlICh1bnBfZGVmZXIpOw0KIAlzeF9zdW5s b2NrKCZmaWxlbGlzdF9sb2NrKTsNCiAJLyoNCisJICogWFhYUlc6IFRoZSBm b2xsb3dpbmcgY29tbWVudHMgbmVlZCB1cGRhdGluZyBmb3IgYSBwb3N0LVNN UG5nIGFuZA0KKwkgKiBkZWZlcnJlZCB1bnBfZ2MoKSB3b3JsZCwgYnV0IGFy ZSBzdGlsbCBnZW5lcmFsbHkgYWNjdXJhdGUuDQorCSAqDQogCSAqIFdlIGdy YWIgYW4gZXh0cmEgcmVmZXJlbmNlIHRvIGVhY2ggb2YgdGhlIGZpbGUgdGFi bGUgZW50cmllcw0KIAkgKiB0aGF0IGFyZSBub3Qgb3RoZXJ3aXNlIGFjY2Vz c2libGUgYW5kIHRoZW4gZnJlZSB0aGUgcmlnaHRzDQogCSAqIHRoYXQgYXJl IHN0b3JlZCBpbiBtZXNzYWdlcyBvbiB0aGVtLg0KQEAgLTE3ODgsMTIgKzE3 ODgsMTEgQEANCiAJCQlGSUxFX1VOTE9DSyh0ZnApOw0KIAkJfQ0KIAl9DQot CWZvciAoaSA9IG51bnJlZiwgZnBwID0gZXh0cmFfcmVmOyAtLWkgPj0gMDsg KytmcHApDQorCWZvciAoaSA9IG51bnJlZiwgZnBwID0gZXh0cmFfcmVmOyAt LWkgPj0gMDsgKytmcHApIHsNCiAJCWNsb3NlZigqZnBwLCAoc3RydWN0IHRo cmVhZCAqKSBOVUxMKTsNCisJCXVucF9yZWN5Y2xlZCsrOw0KKwl9DQogCWZy ZWUoZXh0cmFfcmVmLCBNX1RFTVApOw0KLQl1bnBfZ2NpbmcgPSAwOw0KLQ0K LQlVTlBfVU5MT0NLX0FTU0VSVCgpOw0KIH0NCiANCiB2b2lkDQo= --0-1698448597-1131573310=:33260 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=closef_threadnull.diff Content-Transfer-Encoding: BASE64 Content-ID: <20051109215510.W33260@fledge.watson.org> Content-Description: Content-Disposition: attachment; filename=closef_threadnull.diff SW5kZXg6IGtlcm5fZGVzY3JpcC5jDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvc3lzL2tlcm4va2Vybl9kZXNj cmlwLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjI4Mw0KcmV0cmlldmlu ZyByZXZpc2lvbiAxLjI4NA0KZGlmZiAtdSAtcjEuMjgzIC1yMS4yODQNCi0t LSBrZXJuX2Rlc2NyaXAuYwkxIE5vdiAyMDA1IDE3OjEzOjA1IC0wMDAwCTEu MjgzDQorKysga2Vybl9kZXNjcmlwLmMJOSBOb3YgMjAwNSAyMDo1NDoyNSAt MDAwMAkxLjI4NA0KQEAgLTE4ODAsOSArMTg4MCwxMyBAQA0KIAkgKiBhIGZs YWcgaW4gdGhlIHVubG9jayB0byBmcmVlIE9OTFkgbG9ja3Mgb2JleWluZyBQ T1NJWA0KIAkgKiBzZW1hbnRpY3MsIGFuZCBub3QgdG8gZnJlZSBCU0Qtc3R5 bGUgZmlsZSBsb2Nrcy4NCiAJICogSWYgdGhlIGRlc2NyaXB0b3Igd2FzIGlu IGEgbWVzc2FnZSwgUE9TSVgtc3R5bGUgbG9ja3MNCi0JICogYXJlbid0IHBh c3NlZCB3aXRoIHRoZSBkZXNjcmlwdG9yLg0KKwkgKiBhcmVuJ3QgcGFzc2Vk IHdpdGggdGhlIGRlc2NyaXB0bywgYW5kIHRoZSB0aHJlYWQgcG9pbnRlcg0K KwkgKiB3aWxsIGJlIE5VTEwuICBDYWxsZXJzIHNob3VsZCBiZSBjYXJlZnVs IG9ubHkgdG8gcGFzcyBhDQorCSAqIE5VTEwgdGhyZWFkIHBvaW50ZXIgd2hl biB0aGVyZSByZWFsbHkgaXMgbm8gb3duaW5nDQorCSAqIGNvbnRleHQgdGhh dCBtaWdodCBoYXZlIGxvY2tzLCBvciB0aGUgbG9ja3Mgd2lsbCBiZQ0KKwkg KiBsZWFrZWQuDQogCSAqLw0KLQlpZiAoZnAtPmZfdHlwZSA9PSBEVFlQRV9W Tk9ERSkgew0KKwlpZiAoZnAtPmZfdHlwZSA9PSBEVFlQRV9WTk9ERSAmJiB0 ZCAhPSBOVUxMKSB7DQogCQlpbnQgdmZzbG9ja2VkOw0KIA0KIAkJdnAgPSBm cC0+Zl92bm9kZTsNCg== --0-1698448597-1131573310=:33260--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051109215200.M33260>