From owner-svn-ports-all@freebsd.org  Sat Mar 25 03:28:51 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD73BD0FE95;
 Sat, 25 Mar 2017 03:28:51 +0000 (UTC) (envelope-from db@db.net)
Received: from diana.db.net (diana.db.net [66.113.102.10])
 by mx1.freebsd.org (Postfix) with ESMTP id CAD381EFF;
 Sat, 25 Mar 2017 03:28:51 +0000 (UTC) (envelope-from db@db.net)
Received: from night.db.net (localhost [127.0.0.1])
 by diana.db.net (Postfix) with ESMTP id CC08A2AA4B9;
 Fri, 24 Mar 2017 21:27:32 -0600 (MDT)
Received: by night.db.net (Postfix, from userid 1000)
 id 0875F39873; Fri, 24 Mar 2017 23:28:43 -0400 (EDT)
Date: Fri, 24 Mar 2017 23:28:42 -0400
From: Diane Bruce <db@db.net>
To: Kyle Evans <bsdports@kyle-evans.net>
Cc: Alexey Dokuchaev <danfe@freebsd.org>, Diane Bruce <db@freebsd.org>,
 svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r436814 - in head/comms: . direwolf direwolf/files
Message-ID: <20170325032842.GA90279@night.db.net>
References: <201703241401.v2OE1nwY023666@repo.freebsd.org>
 <20170325014740.GC54562@FreeBSD.org>
 <CACNAnaFhG=WufG3VP3TG6CZWf507X=OFWzif2YUm8==JDKEuGg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACNAnaFhG=WufG3VP3TG6CZWf507X=OFWzif2YUm8==JDKEuGg@mail.gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Mar 2017 03:28:52 -0000

On Fri, Mar 24, 2017 at 09:28:26PM -0500, Kyle Evans wrote:
> On Fri, Mar 24, 2017 at 8:47 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > It was not explained why the FreeBSD version of Makefile is needed at all.
> > What's wrong with original version?  Most of its contents are not related
> > to FreeBSD in any way.
> 
> The project Makefile does a basic OS check then includes
> Makefile.{linux,macosx,win}. The linux/macosx makefiles contain enough
> platform specific things that we saw fit to write a FreeBSD version.
> We're doing some work with upstream to get this integrated into
> Direwolf in a manner that's more maintainable by all.

It looked as if upstream simply preferred a separate platform
specific Makefile much as other projects have done in the past;
But after requesting a pull request upstream expressed a preference
for a single Makefile and work was started on this.

> 
> I'm attaching a patch that should address your concerns, with
> PORTREVISION bumped due to the dw-start.sh change -- /usr/local was

I note that upstream already have a change we can pull in with
next iteration hence a PORTREVISION will not be necessary.

> 
> Thanks,
> 
> Kyle Evans

-- 
- db@FreeBSD.org db@db.net http://www.db.net/~db