Date: Fri, 11 Jun 2010 06:48:59 GMT From: Sascha Holzleiter <sascha@root-login.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/147781: audio/murmur: Murmur overwrites the configfile with each install Message-ID: <201006110648.o5B6mxRI088119@www.freebsd.org> Resent-Message-ID: <201006110650.o5B6o1f7087903@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 147781
>Category: ports
>Synopsis: audio/murmur: Murmur overwrites the configfile with each install
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Jun 11 06:50:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Sascha Holzleiter
>Release: 8.0-STABLE
>Organization:
>Environment:
FreeBSD dreamland.office.local 8.0-STABLE FreeBSD 8.0-STABLE #1: Wed Feb 17 16:26:37 CET 2010 root@dreamland.office.local:/usr/obj/usr/src/sys/DREAMLAND amd64
>Description:
When installing the murmur port the do-install Target copies the config file (murmur.ini) from the distribution even if it already exists in $PREFIX/etc
>How-To-Repeat:
cd /usr/ports/audio/murmur && make install
>Fix:
Attached is a short diff which copies the file as murmur.ini.sample to PREFIX/etc and only copies it to PREFIX/etc/murmur.ini if that doesn't already exist.
Patch attached with submission follows:
diff -u murmur.orig/Makefile murmur/Makefile
--- murmur.orig/Makefile 2010-06-11 08:35:55.000000000 +0200
+++ murmur/Makefile 2010-06-11 08:40:53.000000000 +0200
@@ -73,7 +73,10 @@
do-install:
@${INSTALL_PROGRAM} ${WRKSRC}/release/murmurd ${PREFIX}/sbin
- @${INSTALL_DATA} ${WRKSRC}/scripts/murmur.ini ${PREFIX}/etc
+ @${INSTALL_DATA} ${WRKSRC}/scripts/murmur.ini ${PREFIX}/etc/murmur.ini.sample
+ @if [ ! -f ${PREFIX}/etc/murmur.ini ]; then \
+ ${CP} -p ${PREFIX}/etc/murmur.ini.sample ${PREFIX}/etc/murmur.ini; \
+ fi
${INSTALL_MAN} ${WRKSRC}/man/murmurd.1 ${MANPREFIX}/man/man1
.if !defined(NOPORTDOCS)
@${MKDIR} ${DOCSDIR}
Common subdirectories: murmur.orig/files and murmur/files
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006110648.o5B6mxRI088119>