From owner-freebsd-multimedia@FreeBSD.ORG  Fri Dec 17 18:04:56 2010
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 76DDE1065670;
	Fri, 17 Dec 2010 18:04:56 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200])
	by mx1.freebsd.org (Postfix) with ESMTP id DC30C8FC1A;
	Fri, 17 Dec 2010 18:04:55 +0000 (UTC)
Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua
	[10.1.1.148])
	by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id oBHI4pWm095347
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 17 Dec 2010 20:04:51 +0200 (EET)
	(envelope-from kostikbel@gmail.com)
Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1])
	by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id
	oBHI4pHT093748; Fri, 17 Dec 2010 20:04:51 +0200 (EET)
	(envelope-from kostikbel@gmail.com)
Received: (from kostik@localhost)
	by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id oBHI4ohR093746; 
	Fri, 17 Dec 2010 20:04:50 +0200 (EET)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to
	kostikbel@gmail.com using -f
Date: Fri, 17 Dec 2010 20:04:50 +0200
From: Kostik Belousov <kostikbel@gmail.com>
To: Andriy Gapon <avg@freebsd.org>
Message-ID: <20101217180450.GQ33073@deviant.kiev.zoral.com.ua>
References: <4D05332C.7010208@freebsd.org> <4D0B9752.6020308@freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="wZTxhqwJpWaw9Sch"
Content-Disposition: inline
In-Reply-To: <4D0B9752.6020308@freebsd.org>
User-Agent: Mutt/1.4.2.3i
X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua
X-Virus-Status: Clean
X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DNS_FROM_OPENWHOIS autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	skuns.kiev.zoral.com.ua
Cc: freebsd-multimedia@freebsd.org, Martin Matuska <mm@freebsd.org>
Subject: Re: ffmpeg and mmap
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Dec 2010 18:04:56 -0000


--wZTxhqwJpWaw9Sch
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 17, 2010 at 07:01:06PM +0200, Andriy Gapon wrote:
> The above check should also be fixed for the case when mmap is used.
> mmap returns MAP_FAILED in case of failure and on FreeBSD MAP_FAILED != NULL.
> Not sure about Linux, but we probably don't care - if only to report to upstream
> to make their code cleaner.
NULL is the valid return value from mmap() for FreeBSD address map
both on i386 and amd64.

--wZTxhqwJpWaw9Sch
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAk0LpkIACgkQC3+MBN1Mb4hVpQCgrRYYi+m0Wd7VbPfjzHBSwUIq
4IkAni1kRI8bGUQhDw8iZ16PG+6KKzK3
=Q/s4
-----END PGP SIGNATURE-----

--wZTxhqwJpWaw9Sch--