Date: Mon, 25 Jul 2011 03:19:38 GMT From: Pedro Giffuni <giffunip@tutopia.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/159173: cad/spice: more CLANG fixes Message-ID: <201107250319.p6P3Jcms096462@red.freebsd.org> Resent-Message-ID: <201107250320.p6P3KAGh077943@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 159173
>Category: ports
>Synopsis: cad/spice: more CLANG fixes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Jul 25 03:20:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Pedro Giffuni
>Release: 9.0-CURRENT
>Organization:
>Environment:
FreeBSD mogwai.giffuni.net 9.0-CURRENT FreeBSD 9.0-CURRENT #6: Sat Apr 30 01:37:57 PDT 2011 root@build9x64.pcbsd.org:/usr/obj/pcbsd-build90/fbsd-source/9.0/sys/PCBSD amd64
>Description:
Second round of clang fixes from latest pointyhat build:
- add "void" as the return type for some functions
- no functional change (still builds with gcc)
>How-To-Repeat:
>Fix:
Patch attached.
Patch attached with submission follows:
diff -ruN spice.orig/files/patch-src_lib_fte_device_c spice/files/patch-src_lib_fte_device_c
--- spice.orig/files/patch-src_lib_fte_device_c 2011-07-24 21:49:01.000000000 +0000
+++ spice/files/patch-src_lib_fte_device_c 2011-07-24 21:58:31.000000000 +0000
@@ -1,6 +1,14 @@
---- src/lib/fte/device.c.orig Thu Jul 29 19:09:59 1993
-+++ src/lib/fte/device.c Thu Sep 30 13:16:51 2004
-@@ -619,7 +619,7 @@
+--- src/lib/fte/device.c.orig 1993-07-30 02:09:59.000000000 +0000
++++ src/lib/fte/device.c 2011-07-24 21:57:11.000000000 +0000
+@@ -576,6 +576,7 @@
+ com_alter_common(wl, 1);
+ }
+
++void
+ com_alter_common(wl, do_model)
+ wordlist *wl;
+ int do_model;
+@@ -619,7 +620,7 @@
n2 = names;
}
@@ -9,7 +17,7 @@
fprintf(cp_err, "alter: don't understand \"%s\"\n", names->pn_name);
fprintf(cp_err, "usage: alter dev param = expression\n");
fprintf(cp_err, " or alter @dev[param] = expression\n");
-@@ -661,7 +661,9 @@
+@@ -661,7 +662,9 @@
}
dv = ft_evaluate(n2->pn_right);
diff -ruN spice.orig/files/patch-src_lib_fte_x11_c spice/files/patch-src_lib_fte_x11_c
--- spice.orig/files/patch-src_lib_fte_x11_c 2011-07-24 21:49:01.000000000 +0000
+++ spice/files/patch-src_lib_fte_x11_c 2011-07-24 22:06:03.000000000 +0000
@@ -1,5 +1,5 @@
---- src/lib/fte/x11.c.orig Wed Apr 14 21:44:56 1993
-+++ src/lib/fte/x11.c Sun Aug 15 19:06:31 2004
+--- src/lib/fte/x11.c.orig 1993-04-14 19:44:56.000000000 +0000
++++ src/lib/fte/x11.c 2011-07-24 22:04:30.000000000 +0000
@@ -120,7 +120,10 @@
/* "invert" works better than "xor" for B&W */
@@ -41,7 +41,15 @@
}
-@@ -942,7 +946,8 @@
+@@ -915,6 +919,7 @@
+ }
+ # endif
+
++void
+ X11_Input(request, response)
+ REQUEST *request;
+ RESPONSE *response;
+@@ -942,7 +947,8 @@
1 << ConnectionNumber(display);
/* block on ConnectionNumber and request->fp */
@@ -51,7 +59,7 @@
/* handle X events first */
if (readfds & (1 << ConnectionNumber(display))) {
-@@ -995,7 +1000,8 @@
+@@ -995,7 +1001,8 @@
}
diff -ruN spice.orig/files/patch-src_lib_mfb_mfbgnc_c spice/files/patch-src_lib_mfb_mfbgnc_c
--- spice.orig/files/patch-src_lib_mfb_mfbgnc_c 1970-01-01 00:00:00.000000000 +0000
+++ spice/files/patch-src_lib_mfb_mfbgnc_c 2011-07-24 22:13:31.000000000 +0000
@@ -0,0 +1,10 @@
+--- src/lib/mfb/mfbgnc.c.orig 2011-07-24 22:09:03.000000000 +0000
++++ src/lib/mfb/mfbgnc.c 2011-07-24 22:12:08.000000000 +0000
+@@ -100,6 +100,7 @@
+ * all other characters are ``self-inserting''.
+ */
+
++void
+ MFBGenCode(PM)
+ char *PM;
+ {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107250319.p6P3Jcms096462>