Date: Wed, 18 Jan 1995 19:14:05 +0300 From: "Andrew A. Chernov, Black Mage" <ache@astral.msk.su> To: Doug Rabson <dfr@render.com>, "Paul F. Werkowski" <pw@snoopy.MV.COM> Cc: freebsd-hackers@freefall.cdrom.com Subject: Re: old vfprintf bug back again in 2.x Message-ID: <gCDvJ7lGH1@astral.msk.su> In-Reply-To: <Pine.BSF.3.91.950118110149.3845C-100000@minnow.render.com>; from Doug Rabson at Wed, 18 Jan 1995 11:06:59 %2B0000 (GMT) References: <Pine.BSF.3.91.950118110149.3845C-100000@minnow.render.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.3.91.950118110149.3845C-100000@minnow.render.com>
Doug Rabson writes:
>I looked into this and I believe that this patch does the same job:
>*** /usr/src/lib/libc/stdio/vfprintf.c Fri May 27 05:57:31 1994
>--- vfprintf.c Mon Dec 19 16:46:42 1994
>***************
>*** 507,512 ****
>--- 507,514 ----
> prec = (prec == -1) ?
> DEFPREC + 1 : prec + 1;
> /* FALLTHROUGH */
>+ if (prec != 0)
>+ flags |= ALT;
> goto fp_begin;
> case 'f': /* always print trailing zeroes */
> if (prec != 0)
>It certainly helps GCL anyway. Unless you have any objections, I will
>commit this smaller patch as it seems to be a bit less intrusive.
I think this patch can be even smaller (only one line affected),
just remove "goto fp_begin"
after FALLTHROUGH (which really means it without goto fp_begin).
--
Andrew A. Chernov : And I rest so composedly, /Now, in my bed,
ache@astral.msk.su : That any beholder /Might fancy me dead -
FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead.
RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?gCDvJ7lGH1>