From owner-freebsd-net@FreeBSD.ORG  Thu Feb 12 20:10:00 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B2CE5512
 for <freebsd-net@freebsd.org>; Thu, 12 Feb 2015 20:10:00 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9304536C
 for <freebsd-net@freebsd.org>; Thu, 12 Feb 2015 20:10:00 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1CJvaVJ096849
 for <freebsd-net@freebsd.org>; Thu, 12 Feb 2015 19:57:36 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1CJvacv096848;
 Thu, 12 Feb 2015 19:57:36 GMT (envelope-from root)
Date: Thu, 12 Feb 2015 19:57:36 +0000
To: freebsd-net@freebsd.org
From: "glebius (Gleb Smirnoff)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Accepted] D1764: Factor out ip6_deletefraghdr()
Message-ID: <720c91516a1387525d27956bbda1b04b@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1764: Factor out ip6_deletefraghdr()
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-ejqqvwsrqxen3vd3xete>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-Cc: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-ujqzt6y23l6hpvvcstqn-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-ujqzt6y23l6hpvvcstqn-req@FreeBSD.org>
Thread-Index: ZDE3NDlmNTBjMTFkOWUxZjE5ZTU2MDhhM2Q4IFTdBbA=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-cc>, <differential-other>,
 <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2015 20:10:00 -0000

glebius added a subscriber: glebius.
glebius accepted this revision.
glebius added a reviewer: glebius.
glebius added a comment.
This revision is now accepted and ready to land.

Thanks. Patch looks good to me, but see comments. We probably need a nod from a IPv6 expert. I'll send link to ae@.

INLINE COMMENTS
  sys/netinet6/ip6_output.c:1215 Comment should end in dot.
  sys/netinet6/ip6_output.c:1217 Comment should end in dot.
  sys/netinet6/ip6_output.c:1218 Can you please use bcopy() here. And you don't need first caddr_t cast. The second cast should be changed to char *.
  sys/netinet6/ip6_output.c:1223 Please capitalize comment and end it in dot.
  sys/netinet6/ip6_output.c:1224 Let's add third argument 'wait' to ip6_deletefraghdr(). The argument will be passed directly to m_split().
  sys/netinet6/ip6_var.h:391 Need single whitespace between 'mbuf' and '*'.

REVISION DETAIL
  https://reviews.freebsd.org/D1764

To: kristof, glebius
Cc: glebius, freebsd-net