From owner-svn-src-all@freebsd.org Sat Feb 16 06:25:35 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC57B14D67BA for ; Sat, 16 Feb 2019 06:25:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E844175167 for ; Sat, 16 Feb 2019 06:25:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x831.google.com with SMTP id y20so13533810qtm.13 for ; Fri, 15 Feb 2019 22:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oGn1rFFiMbS0RrtPnQj83vEUwoeq23DmIJXadG5wgS4=; b=mBYvJ+b0NXRQe3wyAhqZ1Wo6pPzvHHvx/sn+khk8lNn/4w2xUkpR3es/OJRv6qyXdz iTKK++5t2kcCnJVjIp72L2XivevXJ9BilkOahixfChsXvdkAR46H0pbeqnMGuBRBSwmm lo5KqiEcJl9YZnKQX17FAr0CeOv5Idya/w7xgz9qWWHM/o+dm5wzhH717RkMHGC7GJMJ 9WSGiYAo/w32TRG443HRcR2Xf77009rk2+d60rWfVhDdNubN/2Er+rmG61MU/3KZCMHC +S/RR0ngoyYLsM2r+MPsUgsYrj0YCn3Qd/jSZncjOmRHRzP1WvmZaPc4JEhPVil5wBka 0Fog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oGn1rFFiMbS0RrtPnQj83vEUwoeq23DmIJXadG5wgS4=; b=jXmBReWM/Jcry2VE1CgYVTCiqj8YyuZlur2zHuemiYcpJwo3SLqvR0kz/41q/2cEvO AL4aV2bphvPt6x6fQSUnQ499rGRDxcz5PGLFuB1IJQU6DW3YJnVL38TQsi6y5/PlAlaC voCXHX0qNX3pTmqGwwwb3EYoT58MAmKMNA0IHpdQ/QnY3+AqLKgffUKG4RACUvvW7vQP yQ4BNimu8WcYXB4bIHHAQqlJrR7gdgSMQMGHkiSFWqY+1lI2BgsUMMcz+2+Zr7S7f9Sr 37waMePiAEGcv9KPmZf0iflhLjRSFCvIJMpkRv45i0ht8XONXPxKZGrijJWmCLb0Pwkg 57+A== X-Gm-Message-State: AHQUAuZU59YhxelpBYnGwLP95I+FTGDbXmvcz2mLIjW4jeF7A52GEapb Dd1PGaILr5wRjGorxxXlW+uTnRcGFnvuEF7Ori31pERl X-Google-Smtp-Source: AHgI3IbdixSR7a5yS9ozoqgjpCc43TEAAmlvGx1Pe1VvISX/sPWHCm2sJKE2T/HNIfY1Ud/HeEMAF1ciqFQqYCWKydM= X-Received: by 2002:ac8:3974:: with SMTP id t49mr10750439qtb.118.1550298333279; Fri, 15 Feb 2019 22:25:33 -0800 (PST) MIME-Version: 1.0 References: <201902160015.x1G0F3EJ060777@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Fri, 15 Feb 2019 23:25:20 -0700 Message-ID: Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol To: Garrett Cooper Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: E844175167 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=mBYvJ+b0 X-Spamd-Result: default: False [-5.40 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[ALT1.aspmx.l.google.com,aspmx.l.google.com,ALT2.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[1.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.68)[-0.680,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-2.71)[ip: (-8.89), ipnet: 2607:f8b0::/32(-2.59), asn: 15169(-1.99), country: US(-0.07)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2019 06:25:35 -0000 On Fri, Feb 15, 2019, 9:55 PM Enji Cooper > > On Feb 15, 2019, at 16:15, Warner Losh wrote: > > > > Author: imp > > Date: Sat Feb 16 00:15:02 2019 > > New Revision: 344191 > > URL: https://svnweb.freebsd.org/changeset/base/344191 > > > > Log: > > Remove write-only s_flag. > > > > Modified: > > head/sbin/nvmecontrol/firmware.c > > > > Modified: head/sbin/nvmecontrol/firmware.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 > (r344190) > > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 > (r344191) > > @@ -177,7 +177,7 @@ static void > > firmware(const struct nvme_function *nf, int argc, char *argv[]) > > { > > int fd =3D -1, slot =3D 0; > > - int a_flag, s_flag, f_flag; > > + int a_flag, f_flag; > > int activate_action, reboot_required; > > int opt; > > char *p, *image =3D NULL; > > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int argc, > cha > > uint8_t fw_slot1_ro, fw_num_slots; > > struct nvme_controller_data cdata; > > > > - a_flag =3D s_flag =3D f_flag =3D false; > > + a_flag =3D f_flag =3D false; > > > > while ((opt =3D getopt(argc, argv, "af:s:")) !=3D -1) { > > Hi Warner! > Should =E2=80=9Cs:=E2=80=9D be removed here, along with any correspon= ding > documentation about =E2=80=98-s foo=E2=80=99? > The docs are poo. s: should not be removed, since it is the slot and required. The code set slot and s_flag. The latter is bogus, so I removed it. Warner >