Date: Wed, 23 Nov 2016 19:47:12 +0300 From: Konstantin Tokarev <annulen@yandex.ru> To: Hans Petter Selasky <hps@selasky.org>, Ed Schouten <ed@nuxi.nl> Cc: "ports@freebsd.org" <ports@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Slawa Olhovchenkov <slw@zxy.spb.ru> Subject: Re: Optimising generated rules for SAT solving (5/12 are duplicates) Message-ID: <402001479919632@web11o.yandex.ru> In-Reply-To: <e9e1571b-443a-2452-926b-1d9f5b2f8e37@selasky.org> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net> <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org> <cbc964a7-5f90-6ea1-630d-414de68867b1@selasky.org> <CABh_MKm7LAtQzp9KEBpaRZWQQHnsUtNFiKVSVF70-wj4GmytuA@mail.gmail.com> <e9e1571b-443a-2452-926b-1d9f5b2f8e37@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
23.11.2016, 19:42, "Hans Petter Selasky" <hps@selasky.org>: > On 11/23/16 17:27, Ed Schouten wrote: >> Hi Hans, >> >> 2016-11-23 15:27 GMT+01:00 Hans Petter Selasky <hps@selasky.org>: >>> I've made a patch to hopefully optimise SAT solving in our pkg utility. >> >> Nice! Do you by any chance have any numbers that show the performance >> improvements made by this change? > > Hi Ed, > > I tried measuring with "time", but figured out that it was doing a lot > of other stuff too. Isolating this piece of code was not so easy. > > > Assuming that the SAT solver of >> pkg(1) uses an algorithm similar to DPLL[1], a change like this would >> affect performance linearly. My guess is therefore that the running >> time is reduced by approximately 5/12. Is this correct? >> >> By the way, why attach a zip file with a diff? GitHub's pull requests >> are awesome! :-) > > GitHub wouldn't allow me to make a .diff attachment. If you really want to be nasty and not submit your change as a pull request, GitHub allows you to paste your patch as a comment: ```diff <your patch contents here> ``` > >> [1] Davis-Putnam-Logemann-Loveland algorithm: >> https://en.wikipedia.org/wiki/DPLL_algorithm > > --HPS > _______________________________________________ > freebsd-ports@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" -- Regards, Konstantin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?402001479919632>