From owner-svn-ports-head@freebsd.org  Thu Jan 31 14:09:57 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F43014AAECB;
 Thu, 31 Jan 2019 14:09:57 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AA769901A7;
 Thu, 31 Jan 2019 14:09:56 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 9A5341EC34; Thu, 31 Jan 2019 14:09:56 +0000 (UTC)
Date: Thu, 31 Jan 2019 14:09:56 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Diane Bruce <db@db.net>
Cc: Diane Bruce <db@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r491675 - in head/comms/fldigi: . files
Message-ID: <20190131140956.GA93408@FreeBSD.org>
References: <201901310204.x0V24U5Y032910@repo.freebsd.org>
 <20190131021439.GA94120@FreeBSD.org>
 <20190131133732.GA76004@night.db.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190131133732.GA76004@night.db.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: AA769901A7
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.87 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_SHORT(-0.87)[-0.867,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jan 2019 14:09:57 -0000

On Thu, Jan 31, 2019 at 08:37:32AM -0500, Diane Bruce wrote:
> On Thu, Jan 31, 2019 at 02:14:39AM +0000, Alexey Dokuchaev wrote:
> > ...
> > These two patches were essentially not changed and should have been
> > dropped from the commit batch to reduce repo churn and diff noise.
> 
> Tell that to the make makepatch maintainers please.

Well, no: makepatch would never (and it's not supposed to) be so smart
to detect/mitigate these things.  Evaluating a diff (and commit hygiene
in general) is committer's responsibility.

That said, I understand that worrying about diff S/N is not for everyone,
just want to point out that one can control it, and quite easily: simple
svn revert after svn diff/st is usually sufficient.

Clean diffs help the readers, make svn blame'ing and source archaeology
in general easier.

./danfe