From owner-freebsd-stable@FreeBSD.ORG  Tue Apr 19 07:13:07 2005
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1734F16A4CE
	for <freebsd-stable@freebsd.org>;
	Tue, 19 Apr 2005 07:13:07 +0000 (GMT)
Received: from web54004.mail.yahoo.com (web54004.mail.yahoo.com
	[206.190.36.228])
	by mx1.FreeBSD.org (Postfix) with SMTP id 7FA1143D2F
	for <freebsd-stable@freebsd.org>;
	Tue, 19 Apr 2005 07:13:06 +0000 (GMT)
	(envelope-from spamrefuse@yahoo.com)
Received: (qmail 60772 invoked by uid 60001); 19 Apr 2005 07:13:05 -0000
Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=s1024; d=yahoo.com;
	b=qSsgDOavZqIPj8nYXiDOf0X3FWg1LXl4xv0LrsWsC2cU/j1TkrdWKt+EvAGRd33xXXH/EtisNDpdvYx4r/VefLI1eTDvvzs+3qS5EHQnS/rPkYPhytCr0odBTVL2ofUCLyeikh3loTlBiXwecZwbM/EmoXBVoTgA4At9GoFer+4=
	;
Message-ID: <20050419071305.60770.qmail@web54004.mail.yahoo.com>
Received: from [147.46.44.181] by web54004.mail.yahoo.com via HTTP;
	Tue, 19 Apr 2005 00:13:05 PDT
Date: Tue, 19 Apr 2005 00:13:05 -0700 (PDT)
From: Rob <spamrefuse@yahoo.com>
To: Kris Kennaway <kris@obsecurity.org>
In-Reply-To: 6667
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
cc: FreeBSD Stable <freebsd-stable@freebsd.org>
Subject: [PATCH] Re: /etc/rc.d/sshd : "kldload random" missing?
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2005 07:13:07 -0000


--- Kris Kennaway <kris@obsecurity.org> wrote:
> On Sun, Apr 17, 2005 at 08:48:37PM -0700, Rob wrote:
> > 
> > Hi,
> > 
> > I noticed that 'random.ko' module is required
> > by ssh, especially when running the server sshd.
> > However, the sshd script in /etc/rc.d does not
> > verify the pressence of the random.ko module and
> > neither loads it if necessary. Shouldn't that be
> > added?
> > 
> > I bring this up, since I have observed that the
> > nfsserver.ko module is automagically loaded by the
> > /etc/rc.d/nfsserver script.
> > 
> > Both cases seem to have some similarity.
> 
> Sounds like a great opportunity to submit a patch!
> :)


Should I submit a patch here?

Following patch works fine for me
(be aware some lines are wrapped :[ )

--- /etc/rc.d/sshd       Sun Oct 10 18:50:54 2004
+++ /etc/rc.d/sshd       Tue Apr 19 15:56:12 2005
@@ -80,6 +80,14 @@
 
 sshd_precmd()
 {
+        if !  ${SYSCTL} kern.random >/dev/null 2>&1;
then
+                if ! kldload random; then
+                        warn 'Could not load random
module'
+                        return 1
+                fi
+        fi
+
         if [ ! -f /etc/ssh/ssh_host_key -o \
             ! -f /etc/ssh/ssh_host_dsa_key -o \
             ! -f /etc/ssh/ssh_host_rsa_key ]; then



		
__________________________________ 
Do you Yahoo!? 
Make Yahoo! your home page 
http://www.yahoo.com/r/hs