From owner-freebsd-firewire@FreeBSD.ORG Fri Dec 21 01:27:41 2007 Return-Path: Delivered-To: freebsd-firewire@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83BD916A417 for ; Fri, 21 Dec 2007 01:27:41 +0000 (UTC) (envelope-from freebsd@gm.nunu.org) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.225]) by mx1.freebsd.org (Postfix) with ESMTP id 4E5F213C45D for ; Fri, 21 Dec 2007 01:27:41 +0000 (UTC) (envelope-from freebsd@gm.nunu.org) Received: by nz-out-0506.google.com with SMTP id l8so76883nzf.13 for ; Thu, 20 Dec 2007 17:27:40 -0800 (PST) Received: by 10.142.142.16 with SMTP id p16mr448078wfd.119.1198200459844; Thu, 20 Dec 2007 17:27:39 -0800 (PST) Received: by 10.142.224.12 with HTTP; Thu, 20 Dec 2007 17:27:39 -0800 (PST) Message-ID: <626eb4530712201727n3fc0d33aq6e6b44603b5d77f2@mail.gmail.com> Date: Fri, 21 Dec 2007 10:27:39 +0900 From: "Hidetoshi Shimokawa" Sender: freebsd@gm.nunu.org To: "Sean Bruno" In-Reply-To: <476B13F4.5050409@miralink.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <476610E5.2060108@miralink.com> <626eb4530712162258s4dfe1448o1102f20a623d3f95@mail.gmail.com> <476696C4.60408@miralink.com> <626eb4530712182320q237c344crd309893a82fe8ef8@mail.gmail.com> <476B13F4.5050409@miralink.com> X-Google-Sender-Auth: 16cadc62d94b0d76 Cc: freebsd-firewire@freebsd.org Subject: Re: sbp_targ memory leak X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2007 01:27:41 -0000 Thanks for the test. I'll look into the page_table problem this weekend. Sorry for late response. On 12/21/07, Sean Bruno wrote: > Hidetoshi Shimokawa wrote: > > I think you are right and page table is not freed when CAM_SEND_STATUS > > is not set. > > Maybe we should always free page tables if refcont == 0 rather than > > free in sbp_targ_send_status(). > > > > You patch is not just adding debug printfs, right? > > What is the mtx locks for? > > > > On 12/18/07, Sean Bruno wrote: > > > >> Hidetoshi Shimokawa wrote: > >> > >>> Thanks for the tracking of the problem. > >>> Could you resend the patch in unified or context diff? > >>> > >>> Thanks, > >>> > >>> On 12/17/07, Sean Bruno wrote: > >>> > >>> > >>>> In trying to understand and make sbp_targ functional, I've noted that > >>>> the code seems to lose track of how many page tables it allocates for > >>>> any give orbi. I had to add a lot of debugging code around the > >>>> malloc/free's to find out what was going on, and I'm not sure what the > >>>> code is supposed to do in this case. > >>>> > >>>> Please review the patch diff at --> http://consultcsg.com/RELENG_6.diff > >>>> > >>>> And the log at -->http://consultcsg.com/malloc_failure.txt > >>>> > >>>> > >>>> > >>>> > >> Diff updated at http://consultcsg.com/RELENG_6.diff > >> > >> Sean > >> > >> > I moved the free around as you suggested and the memory leak does indeed > go away and there are no further crashes. > Here is my current diff --> http://consultcsg.com/RELENG_6.diff . > > It does look like the data is not being written or read to the backend > correctly however. I.e. the page_table is not being > setup correctly when more than one read or write is required to service > an ORB. Any ideas on how to look into that? > > Sean > > -- /\ Hidetoshi Shimokawa \/ simokawa@FreeBSD.ORG