Date: Thu, 2 Apr 2015 06:31:56 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bartek Rutkowski <robak@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r382946 - head/games/gottet Message-ID: <20150402063156.GC89620@FreeBSD.org> In-Reply-To: <201504011953.t31JrrBR069299@svn.freebsd.org> References: <201504011953.t31JrrBR069299@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 01, 2015 at 07:53:53PM +0000, Bartek Rutkowski wrote: > New Revision: 382946 > URL: https://svnweb.freebsd.org/changeset/ports/382946 > > Log: > games/gottet: update 1.0.6 -> 1.1.1 > - Switch to QT5 Few observations, if you allow me: > [...] > -PORTDOCS= CREDITS ChangeLog NEWS README Why was this line removed? What was wrong with PORTDOCS? It was not mentioned in the log. > +INSTALLS_ICONS= yes As recently pointed out by kwm@ on x11-list, INSTALLS_ICONS is Gtk+-only and thus should not be used for Qt-ports. > - ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR} > + (cd ${WRKSRC} && ${INSTALL_DATA} CREDITS ChangeLog NEWS README \ > + ${STAGEDIR}${DOCSDIR}) Gratuitous change: pointless (non-functional), cryptic, two commands and two lines instead of one, has nothing to do with what commit log taks about, pessimizes "svn blame", etc. In short: it should not have been committed. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150402063156.GC89620>