From owner-freebsd-net@freebsd.org  Tue Oct 31 02:10:09 2017
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1FDE4E47BD5
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Tue, 31 Oct 2017 02:10:09 +0000 (UTC)
 (envelope-from shurd@sasktel.net)
Received: from mail142c7.megamailservers.com (mail542c7.megamailservers.com
 [209.235.141.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9C3F680FB5;
 Tue, 31 Oct 2017 02:10:08 +0000 (UTC)
 (envelope-from shurd@sasktel.net)
X-Authenticated-User: hurds.sasktel.net
X-VIP: 69.49.109.87
Received: from [192.168.1.10] (c-98-209-24-48.hsd1.mi.comcast.net
 [98.209.24.48]) (authenticated bits=0)
 by mail142c7.megamailservers.com (8.14.9/8.13.1) with ESMTP id v9V22DoC020526; 
 Mon, 30 Oct 2017 22:02:15 -0400
Subject: Re: LOR in iflib_timer
To: Eric van Gyzen <vangyzen@FreeBSD.org>, shurd@FreeBSD.org,
 sbruno@FreeBSD.org, freebsd-net@freebsd.org
References: <32cdf984-fa30-331c-f7b0-2bec1f13a6cf@FreeBSD.org>
From: Stephen Hurd <shurd@sasktel.net>
Message-ID: <a46362a5-62f7-17af-a653-10cfa9ef4558@sasktel.net>
Date: Mon, 30 Oct 2017 22:02:13 -0400
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:51.0) Gecko/20100101
 Firefox/51.0 SeaMonkey/2.48
MIME-Version: 1.0
In-Reply-To: <32cdf984-fa30-331c-f7b0-2bec1f13a6cf@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-CTCH-RefID: str=0001.0A020201.59F7D9A7.007C, ss=1, re=0.000, recu=0.000,
 reip=0.000, cl=1, cld=1, fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
X-CTCH-Score: 0.000
X-CTCH-Rules: 
X-CTCH-Flags: 0
X-CTCH-ScoreCust: 0.000
X-CSC: 0
X-CHA: v=2.2 cv=BuPt+cf5 c=1 sm=1 tr=0 a=58X0Rtt+oPctIZE0oLz+QA==:117
 a=58X0Rtt+oPctIZE0oLz+QA==:17 a=IkcTkHD0fZMA:10 a=6I5d2MoRAAAA:8
 a=Awch3riGIH6IYeVObfIA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Oct 2017 02:10:09 -0000

Eric van Gyzen wrote:
> Twice a day, my router hits an LOR in iflib_timer when it jumps to the 
> "hung" label.  It's running r325049 (head 3 days ago).
>
> lock order reversal:
>  1st 0xfffffe0000f36068 igb1:tx(0):call (igb1:tx(0):call) @ 
> /usr/src/sys/kern/kern_mutex.c:182
>  2nd 0xfffff80003b0c150 igb1 (iflib ctx lock) @ 
> /usr/src/sys/net/iflib.c:2139
>
> This looks like it was fixed by the big rollup.  If it was fixed by a 
> smallish commit, can that commit alone be merged to head?  If someone 
> can point me to the commit, I'd be happy to test it.
>
> Eric

I would guess it to be one of the biggest ones.  Review here: 
https://reviews.freebsd.org/D12101