From owner-svn-src-all@freebsd.org Sat Oct 31 03:32:25 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBD4AA21695; Sat, 31 Oct 2015 03:32:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id CFA261EBD; Sat, 31 Oct 2015 03:32:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id C7C9D1A52; Sat, 31 Oct 2015 03:32:24 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6C35710AD2; Sat, 31 Oct 2015 03:32:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 5rNReA8HNt-S; Sat, 31 Oct 2015 03:32:20 +0000 (UTC) Subject: Re: svn commit: r290220 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 00C5C10AC3 To: NGie Cooper References: <201510310207.t9V27U7U051752@repo.freebsd.org> <563435E1.9020108@FreeBSD.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56343647.7000306@FreeBSD.org> Date: Fri, 30 Oct 2015 20:32:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <563435E1.9020108@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SsTCxFBOI3u2A4DEGLq0a3vnf5LNW3cOO" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2015 03:32:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SsTCxFBOI3u2A4DEGLq0a3vnf5LNW3cOO Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/30/2015 8:30 PM, Bryan Drewery wrote: >=20 >=20 >> On Oct 30, 2015, at 19:18, NGie Cooper wrote: >> >>> On Fri, Oct 30, 2015 at 7:07 PM, Bryan Drewery = wrote: >>> Author: bdrewery >>> Date: Sat Oct 31 02:07:30 2015 >>> New Revision: 290220 >>> URL: https://svnweb.freebsd.org/changeset/base/290220 >>> >>> Log: >>> Don't hide stderr when checking ${CC} --version. >>> >>> This can have important debugging information such as 'cc: not found= ' or >>> 'ccache: error: Could not find compiler "cc" in PATH'. >> >> Won't this spam installworld/distribution a lot? >=20 > Not for me. >=20 > What do you expect from stderr that is non-fatal? The only cases I've > had so far resulted in the .error triggering later due to not being abl= e > to determine compiler type. >=20 > Also, install depending on the compiler type is wrong. We need to > eliminate the cases where it determines SUBDIR or FILES to fix this. I'= d > like to effectively set CC=3Dfalse during install but can't while those= > checks exist. >=20 Setting CC=3Dfalse would cause the warnings, but that's a symptom of the larger problem I mentioned about even using bsd.compiler.mk in install. --=20 Regards, Bryan Drewery --SsTCxFBOI3u2A4DEGLq0a3vnf5LNW3cOO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWNDZHAAoJEDXXcbtuRpfPIFYH/2wGg064z+2mfnluoh32C88y oOL/iJI35Eo2mysVSm9xdkTUtHx/Zvbx7F0yYM1gL6xIyxNYDkywmqDKgA5VXSxY 0fCSn62SjcRTU5222sY7s86NWYqxwwpijvqTwLbLgbeDPASsc7iMl0sCQD+y+r5V 7RrkuQmY5HVmfBis9aprOIxK31Chf9NT8X9xzaH/lecMmVn2Q4iB9NQ3dMdkdxBp rcAJyLkwoosPi6kXtrtFWY39NBFC39O/poxQd0VYrFAKVTgq8k6UEZ4enoxwTYMO g8iel00Y/UvZ6KXcvwLkWfxPFfzDhT0wulcNm9q4yKSWcB8ttG1FEwS7NzOsQQ4= =Dxd/ -----END PGP SIGNATURE----- --SsTCxFBOI3u2A4DEGLq0a3vnf5LNW3cOO--