Date: Mon, 16 Sep 2013 01:21:56 GMT From: Jan Beich <jbeich@tormail.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/182137: [patch] devel/sdl20: disable posix semaphores only if sem.ko is required Message-ID: <201309160121.r8G1LukN034277@oldred.freebsd.org> Resent-Message-ID: <201309160130.r8G1U0HK057820@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182137 >Category: ports >Synopsis: [patch] devel/sdl20: disable posix semaphores only if sem.ko is required >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Sep 16 01:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jan Beich >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: http://svnweb.freebsd.org/changeset/base/201546 http://svnweb.freebsd.org/changeset/base/212852 >Description: After r201546 sem_init(pshared=1) always works without sem.ko but SDL uses sem_init(pshared=0) which worked even before. devel/sdl12 auto-enables sem_init() usage via configure (vendor default). devel/sdl20 unconditionally disables sem_init() usage (port override). Undocumented bug? >How-To-Repeat: >Fix: This or enable everywhere since even sdl12 package for 8.3-RELEASE references sem_init() and works fine. --- sem.diff begins here --- Index: devel/sdl20/Makefile =================================================================== --- devel/sdl20/Makefile (revision 327361) +++ devel/sdl20/Makefile (working copy) @@ -12,7 +12,7 @@ COMMENT= Cross-platform multimedia development API USES= pathfix cmake:outsource iconv USE_LDCONFIG= yes -CMAKE_ARGS+= -DVIDEO_OPENGLES:BOOL=OFF -DPTHREADS_SEM:BOOL=OFF \ +CMAKE_ARGS+= -DVIDEO_OPENGLES:BOOL=OFF \ -DALTIVEC:BOOL=OFF -DARTS:BOOL=OFF CMAKE_ENV+= CFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib" @@ -53,6 +53,10 @@ VIDEO_X11_DESC= X11 rendering support .include <bsd.port.options.mk> +.if ${OSVERSION} < 900007 +CMAKE_ARGS+= -DPTHREADS_SEM:BOOL=OFF +.endif + .if ${PORT_OPTIONS:MALSA} .if !${PORT_OPTIONS:MSDL_AUDIO} IGNORE= option ALSA requires SDL_AUDIO --- sem.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309160121.r8G1LukN034277>