From owner-freebsd-ports  Sun Nov 24 17:49:45 2002
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3AF1537B401; Sun, 24 Nov 2002 17:49:44 -0800 (PST)
Received: from leviathan.inethouston.net (leviathan.inethouston.net [66.64.12.249])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C894B43EA3; Sun, 24 Nov 2002 17:49:43 -0800 (PST)
	(envelope-from dwcjr@inethouston.net)
Received: from dwcjr (unknown [192.168.1.254])
	by leviathan.inethouston.net (Postfix) with SMTP
	id 0DBC610DDC9; Sun, 24 Nov 2002 19:50:07 -0600 (CST)
Message-ID: <007401c29425$27629c70$fe01a8c0@dwcjr>
From: "David W. Chapman Jr." <dwcjr@inethouston.net>
To: "Clive Lin" <clive@tongi.org>
Cc: <freebsd-ports@FreeBSD.org>, <dwcjr@FreeBSD.org>
References: <200211242119.gAOLJhep031439@freefall.freebsd.org> <001401c2941e$0b20bda0$fe01a8c0@dwcjr> <20021125014118.GA94194@fatpipi.cirx.org>
Subject: Re: ports/45691: Add option to disable samba optimization.
Date: Sun, 24 Nov 2002 19:51:21 -0600
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

> > I have cc'd Jerry so that I'm sure he is aware of -O causing this on
> > FreeBSD, but I think we should still force samba to respect CFLAGS
locally.
>
> Wow, well, amazing. Apparently it's a know bug !? If the 'bonus' part
> of PR #45691 is overkill, how about putting a WARNING in pkg-message
> or somewhere, perhaps ?

Yeah, I think it would be more appropriate to put a warning on pkg-message
and make it respect CFLAGS which is basically what you've done already.  If
you want to commit the fixing CFLAGS and add a warning you have my approval.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message