From owner-svn-src-all@freebsd.org Sat Mar 9 08:50:59 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60944153D59D; Sat, 9 Mar 2019 08:50:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 02B30752F2; Sat, 9 Mar 2019 08:50:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id E4219B12; Sat, 9 Mar 2019 08:50:58 +0000 (UTC) Date: Sat, 9 Mar 2019 08:50:58 +0000 From: Alexey Dokuchaev To: Justin Hibbits Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc Message-ID: <20190309085058.GA60945@FreeBSD.org> References: <201903090318.x293IcLc023548@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201903090318.x293IcLc023548@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 02B30752F2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Mar 2019 08:50:59 -0000 On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote: > New Revision: 344960 > URL: https://svnweb.freebsd.org/changeset/base/344960 > > Log: > powerpc: Print trap frame address for fatal traps > > MFC after: 1 week > > Modified: > head/sys/powerpc/powerpc/trap.c > > Modified: head/sys/powerpc/powerpc/trap.c > ============================================================================== > --- head/sys/powerpc/powerpc/trap.c Sat Mar 9 03:15:09 2019 (r344959) > +++ head/sys/powerpc/powerpc/trap.c Sat Mar 9 03:18:37 2019 (r344960) > @@ -546,6 +546,7 @@ printtrap(u_int vector, struct trapframe *frame, int i > printf(" current msr = 0x%" PRIxPTR "\n", mfmsr()); > printf(" lr = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", > frame->lr, frame->lr - (register_t)(__startkernel - KERNBASE)); > + printf(" frame = %p\n", frame); > printf(" curthread = %p\n", curthread); Some of those are printed with %PRIxPTR, some with %p. Perhaps this inconsistency can be avoided? ./danfe