From owner-freebsd-gnome@freebsd.org Wed May 29 05:29:23 2019 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B5E215B75E5 for ; Wed, 29 May 2019 05:29:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 973448237C for ; Wed, 29 May 2019 05:29:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5853F15B75E2; Wed, 29 May 2019 05:29:22 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 445CF15B75E1 for ; Wed, 29 May 2019 05:29:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BC8AC82378 for ; Wed, 29 May 2019 05:29:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id EEA5313ADF for ; Wed, 29 May 2019 05:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x4T5TKTK057070 for ; Wed, 29 May 2019 05:29:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x4T5TKNf057069 for gnome@FreeBSD.org; Wed, 29 May 2019 05:29:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 238070] x11/cinnamon: Remove unnecessary version check : [Attachment 204680] cinnamon-Remove-unnecessary-version-check.patch v2 Date: Wed, 29 May 2019 05:29:19 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: koobs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 May 2019 05:29:23 -0000 Kubilay Kocak has asked freebsd-gnome mailing list for maintainer-approval: Bug 238070: x11/cinnamon: Remove unnecessary version check https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238070 Attachment 204680: cinnamon-Remove-unnecessary-version-check.patch v2 https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D204680&action=3Dedit --- Comment #3 from Kubilay Kocak --- Created attachment 204680 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D204680&action= =3Dedit cinnamon-Remove-unnecessary-version-check.patch v2 Patch v2, adds fixes for all stage-qa errors and ports/framework compliance: - Add missing LIB_DEPENDS - Add missing USE_{GNOME,X11} components - Add USES=3Dgnome, gl - Fix gstreamer dependencies (GSTREAMER1, not GSTREAMER) - Add LICENCE{_FILE} - Fix more/all shebangs, remove custom REINPLACE_CMD section - Add USES=3Dlocalbase:ldflags, remove CPPFLAGS/LDFLAGS