From owner-freebsd-emulation@FreeBSD.ORG  Thu Dec 13 13:09:00 2012
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 5FD8CC56;
 Thu, 13 Dec 2012 13:09:00 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 7992E8FC19;
 Thu, 13 Dec 2012 13:08:59 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
 [212.40.38.101])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA15818;
 Thu, 13 Dec 2012 15:08:58 +0200 (EET) (envelope-from avg@FreeBSD.org)
Message-ID: <50C9D369.6040204@FreeBSD.org>
Date: Thu, 13 Dec 2012 15:08:57 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: vbox@FreeBSD.org, freebsd-emulation@FreeBSD.org
Subject: incorrect usage of callout_reset in vbox 4.2.4 ?
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Development of Emulators of other operating systems
 <freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2012 13:09:00 -0000


It looks like in timer-r0drv-freebsd.c the code tries to pass absolute time as a
timeout parameter to callout_reset while that function actually expects relative
time (period).

I am testing the following patch, but I am sure that the code can be made more
efficient.

--- timer-r0drv-freebsd.c.orig	2012-12-12 20:13:27.623202784 +0200
+++ timer-r0drv-freebsd.c	2012-12-12 20:19:43.368202795 +0200
@@ -172,15 +172,16 @@
     /*
      * Calc when it should start firing.
      */
-    u64First += RTTimeNanoTS();
+    const uint64_t u64Now = RTTimeNanoTS();
+    u64First += u64Now;

     pTimer->fSuspended = false;
     pTimer->iTick = 0;
     pTimer->u64StartTS = u64First;
     pTimer->u64NextTS = u64First;

-    tv.tv_sec  =  u64First / 1000000000;
-    tv.tv_usec = (u64First % 1000000000) / 1000;
+    tv.tv_sec  =  (u64First - u64Now) / 1000000000;
+    tv.tv_usec = ((u64First - u64Now) % 1000000000) / 1000;
     callout_reset(&pTimer->Callout, tvtohz(&tv), rtTimerFreeBSDCallback, pTimer);

     return VINF_SUCCESS;
@@ -247,8 +248,8 @@
         if (pTimer->u64NextTS < u64NanoTS)
             pTimer->u64NextTS = u64NanoTS + RTTimerGetSystemGranularity() / 2;

-        tv.tv_sec = pTimer->u64NextTS / 1000000000;
-        tv.tv_usec = (pTimer->u64NextTS % 1000000000) / 1000;
+        tv.tv_sec = (pTimer->u64NextTS - u64NanoTS) / 1000000000;
+        tv.tv_usec = ((pTimer->u64NextTS - u64NanoTS) % 1000000000) / 1000;
         callout_reset(&pTimer->Callout, tvtohz(&tv), rtTimerFreeBSDCallback, pTimer);
     }



-- 
Andriy Gapon