From owner-svn-src-all@FreeBSD.ORG  Sat Nov  1 00:51:41 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 44DEA6FF;
 Sat,  1 Nov 2014 00:51:41 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 08971D48;
 Sat,  1 Nov 2014 00:51:40 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 0CEA7A28A;
 Sat,  1 Nov 2014 00:51:40 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 0AC6C109F8; Sat,  1 Nov 2014 01:51:41 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Xin LI <delphij@FreeBSD.org>
Subject: Re: svn commit: r273919 - head/etc/rc.d
References: <201410312220.s9VMKRaO096404@svn.freebsd.org>
Date: Sat, 01 Nov 2014 01:51:41 +0100
In-Reply-To: <201410312220.s9VMKRaO096404@svn.freebsd.org> (Xin LI's message
 of "Fri, 31 Oct 2014 22:20:27 +0000 (UTC)")
Message-ID: <86bnor9202.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Nov 2014 00:51:41 -0000

Xin LI <delphij@FreeBSD.org> writes:
> Log:
>   rc.d/geli should not depend on random, as the attach functionality
>   do not require additional entropy to function.
>=20=20=20
>   It would create a circular dependency (not immediately obvious:
>   geli provides 'disks' and requires 'random' as of r273872,
>   'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root',
>   'root' requires 'swap', and finally 'swap' requires 'disk').

My first instinct was: shouldn't rcorder warn about this?  It turns out
that it does, but in a very cryptic fashion:

des@nine ~head/etc/rc.d% svn up -qr273871=20=20
des@nine ~head/etc/rc.d% rcorder * >/dev/null
des@nine ~head/etc/rc.d% svn up -qr273872=20=20=20=20
des@nine ~head/etc/rc.d% rcorder * >/dev/null
rcorder: Circular dependency on file `zfs'.
rcorder: Circular dependency on provision `mountcritlocal' in file `zfs'.
rcorder: Circular dependency on provision `mountcritlocal' in file `var'.
rcorder: Circular dependency on provision `mountcritlocal' in file `FILESYS=
TEMS'.
rcorder: Circular dependency on provision `root' in file `FILESYSTEMS'.
des@nine ~head/etc/rc.d% svn up -qr273919=20=20=20=20
des@nine ~head/etc/rc.d% rcorder * >/dev/null
des@nine ~head/etc/rc.d%=20

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no