From owner-freebsd-cvsweb@FreeBSD.ORG  Wed Jun  9 06:56:20 2004
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3AC7D16A4D0
	for <freebsd-cvsweb@FreeBSD.org>;
	Wed,  9 Jun 2004 06:56:20 +0000 (GMT)
Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F2A0043D5D
	for <freebsd-cvsweb@FreeBSD.org>;
	Wed,  9 Jun 2004 06:56:19 +0000 (GMT)
	(envelope-from scop@FreeBSD.org)
Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50])
	by smtp1.pp.htv.fi (Postfix) with ESMTP
	id E9A28817F3; Wed,  9 Jun 2004 09:56:18 +0300 (EEST)
Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181])
	/8.11.1) with ESMTP id i596uIJ26284;
	Wed, 9 Jun 2004 09:56:18 +0300 (EETDST)
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org>
To: freebsd-cvsweb@FreeBSD.org
In-Reply-To: <1086641586.29458.47.camel@bobcat.mine.nu>
References: <20040602171019.GA12732@vgelder.com>
	<20040604095002.GA28772@vgelder.com>
	<1086357443.30172.290.camel@bobcat.mine.nu>
	<1086641586.29458.47.camel@bobcat.mine.nu>
Content-Type: text/plain; charset=ISO-8859-1
Organization: FreeBSD
Message-Id: <1086764177.29458.174.camel@bobcat.mine.nu>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) 
Date: Wed, 09 Jun 2004 09:56:18 +0300
Content-Transfer-Encoding: 8bit
cc: 250757@bugs.debian.org
Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this)
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jun 2004 06:56:20 -0000

On Mon, 2004-06-07 at 23:53, Ville Skyttä wrote:
> On Fri, 2004-06-04 at 16:57, Ville Skyttä wrote:
> > On Fri, 2004-06-04 at 12:50, Koos Vriezen wrote:
> > 
> > > if (defined($ENV{QUERY_STRING})) {
> > >   $ENV{QUERY_STRING} = uri_escape($ENV{QUERY_STRING});
> > >   for my $p (split(/[;&]+/, $ENV{QUERY_STRING})) {
> > [...]
> > > commenting out the 'uri_escape' line makes cvsweb work again.
> > > Up to you and/or debian maintainer to fix this, or is it my perl?
> > 
> > That uri_escape() line does not exist in vanilla FreeBSD-CVSweb, so I
> > guess it's a Debian addition and should be fixed there.
> 
> FYI: I stubled across this:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=250757

...but the uri_unescape() is wrong as well; it will break if the keys or
values in the query string contain eg. a ";".

For example, support for requesting a specific charset along with a
Content-Type is planned; in an escaped query string that will look like:

   ...;content-type=text%2Fhtml%3B%20charset%3DUTF-8;...

Now, if the query string is unescaped before parsing the key=value
pairs, that will become:

   ...;content-type=text/html; charset=UTF-8;...

Parsing that will obviously break.

Debian maintainers, see
http://lists.freebsd.org/pipermail/freebsd-cvsweb/2004-June/000246.html
and later messages in that thread.