From owner-freebsd-current Mon Feb 18 23: 4:22 2002 Delivered-To: freebsd-current@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id 0904637B421 for ; Mon, 18 Feb 2002 23:04:04 -0800 (PST) Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020219070404.XYOP2951.rwcrmhc53.attbi.com@peter3.wemm.org> for ; Tue, 19 Feb 2002 07:04:04 +0000 Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g1J743s35695 for ; Mon, 18 Feb 2002 23:04:03 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id B151F3A9A; Mon, 18 Feb 2002 23:04:03 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Matthew Dillon Cc: current@FreeBSD.ORG Subject: Re: Patch sets to date and timing tests with Giant out of userret. In-Reply-To: <200202190646.g1J6kgE58769@apollo.backplane.com> Date: Mon, 18 Feb 2002 23:04:03 -0800 From: Peter Wemm Message-Id: <20020219070403.B151F3A9A@overcee.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Matthew Dillon wrote: > :> - mtx_lock(&Giant); > :> - td->td_retval[0] = p->p_ucred->cr_ruid; > :> + s = mtx_lock_giant(kern_giant_ucred); > :> + td->td_retval[0] = td->td_ucred->cr_ruid; > :> #if defined(COMPAT_43) || defined(COMPAT_SUNOS) > :> - td->td_retval[1] = p->p_ucred->cr_uid; > :> + td->td_retval[1] = td->td_ucred->cr_uid; > :> #endif > :> - mtx_unlock(&Giant); > :> + mtx_unlock_giant(s); > :> return (0); > : > :What a waste.. John has already done all this stuff already (using > :td_ucred instead of p_ucred) over the entire tree. > : > :Cheers, > :-Peter > > He didn't instrument Giant, and if you actually believe that one > massive commit is going to be more stable then the piecemeal safe-mode > commits I am making then you are smoking something. Or are you > expecting John to commit his patchset piecemeal as well and test > inbetween? If that is so, then he just wasted a whole lot time > managing all this junk in P4 because, frankly, it only took me a few > minutes to instrument the easier system calls. I spend far more > time testing. So, John's last few months of work is junk then, is it? Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message