From owner-freebsd-arch Sat Oct 26 14: 0:20 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 684E437B404 for ; Sat, 26 Oct 2002 14:00:19 -0700 (PDT) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id E18EB43E75 for ; Sat, 26 Oct 2002 14:00:16 -0700 (PDT) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id NAA45530; Sat, 26 Oct 2002 13:53:17 -0700 (PDT) Received: from arch20m.dellroad.org (localhost [127.0.0.1]) by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id g9QKrHON036106; Sat, 26 Oct 2002 13:53:17 -0700 (PDT) (envelope-from archie@arch20m.dellroad.org) Received: (from archie@localhost) by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id g9QKrHMd036105; Sat, 26 Oct 2002 13:53:17 -0700 (PDT) From: Archie Cobbs Message-Id: <200210262053.g9QKrHMd036105@arch20m.dellroad.org> Subject: Re: Renumbering IPPROTO_DIVERT In-Reply-To: <200210260047.RAA01665@windsor.research.att.com> "from Bill Fenner at Oct 25, 2002 05:47:44 pm" To: Bill Fenner Date: Sat, 26 Oct 2002 13:53:17 -0700 (PDT) Cc: julian@elischer.org, arch@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL88 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bill Fenner writes: > >I think though that there should be a "compat" shim that > >does the right thing but is VERY NOISY. > > What's the right thing? How about just always returning an error? Sure, this will prevent non-divert applications that want to speak IP protocol #254 from working, but I don't think any really exist. If they do, they didn't work on many FreeBSD kernels (the ones with IPDIVERT) anyway. By the way, thanks for doing this. The original divert patch was written to be optimized for the shortest possible patchfile rather than the most elegant implementation, hence some of the dumb stuff like stealing an IP protocol number. It's my fault for not cleaning it up first before it got committed. -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message