From owner-freebsd-current  Thu May 16 13:52:39 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id NAA03486
          for current-outgoing; Thu, 16 May 1996 13:52:39 -0700 (PDT)
Received: from vector.jhs.no_domain (slip139-92-42-161.ut.nl.ibm.net [139.92.42.161])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id NAA03465;
          Thu, 16 May 1996 13:52:26 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by vector.jhs.no_domain (8.7.5/8.6.9) with SMTP id NAA06877; Wed, 15 May 1996 13:50:27 +0200 (MET DST)
Message-Id: <199605151150.NAA06877@vector.jhs.no_domain>
X-Authentication-Warning: vector.jhs.no_domain: Host localhost [127.0.0.1] didn't use HELO protocol
To: Wolfram Schneider <wosch@cs.tu-berlin.de>
Cc: current@freebsd.org
Subject: Re: diff for current src/usr.sbin/rmt/Makefile 
From: "Julian H. Stacey" <jhs@freebsd.org>
Reply-To: "Julian H. Stacey" <jhs@freebsd.org>
Organization: Vector Systems Ltd.
Address: Holz Strasse 27d, 80469 Munich, Germany
Phone: +49.89.268616
Fax: +49.89.2608126 (pending modem change)
Web: http://www.freebsd.org/~jhs/
Mailer: EXMH version 1.6.5  95 12 11,  PGP available
In-reply-to: Your message of "Tue, 14 May 1996 12:25:05 +0200."
             <199605141025.MAA00308@campa.panke.de> 
Date: Wed, 15 May 1996 13:50:26 +0200
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Hi, Reference:
> Reply-to: Wolfram Schneider <wosch@cs.tu-berlin.de> 
>
> Julian H. Stacey writes:
> >Here's a diff for src/ tree to prevent a spurious error report in 
> >make transcripts.  Feel free to abbreviate it :-)
> 
> >--- new/src/usr.sbin/rmt/Makefile	Mon May 13 14:06:13 1996
> >  beforeinstall:
> >! 	@if test -e ${DESTDIR}/etc/rmt ;  then			\
> >! 		echo "Pre-existant ${DESTDIR}/etc/rmt" ;	\
> >! 		ls -l ${DESTDIR}/etc/rmt ;			\
> >! 	else 							\
> >! 		echo -n "Creating symbolic link " ;		\
> >! 		echo "${DESTDIR}/etc/rmt --> ${BINDIR}/rmt" ;	\
> >! 		ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt ;	\
> >! 	fi
> 
> should be
> 
> .if exists(${DESTDIR}/etc/rmt)
> 	@${ECHO} ...
> [...]
> .else
> [...]
> .endif

Probably so, this simpler structure would do, if we're happy to allow 
evaluation at Make-invocation-time rather than run time ?
(I have cases in other Makefiles, where I grabbed my syntax from, where
run time is needed, 'cos the dirs. are changing underfoot !)

> And the consensus was that only etc/Makefile change something
> in /etc.

True, so either your fix or my fix should be flipped into
src/etc/Makefile I presume ? Any committers available ?

Julian
--
Julian H. Stacey	jhs@freebsd.org  	http://www.freebsd.org/~jhs/