From owner-cvs-usrsbin Fri Jan 3 09:06:47 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id JAA02674 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 09:06:47 -0800 (PST) Received: from pillar.elsevier.co.uk (root@pillar.elsevier.co.uk [193.131.222.35]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id JAA02536; Fri, 3 Jan 1997 09:03:46 -0800 (PST) Received: from snowdon.elsevier.co.uk (snowdon.elsevier.co.uk [193.131.197.164]) by pillar.elsevier.co.uk (8.8.3/8.8.3) with ESMTP id RAA26857; Fri, 3 Jan 1997 17:02:44 GMT Received: from cadair.elsevier.co.uk by snowdon.elsevier.co.uk with SMTP (PP); Fri, 3 Jan 1997 17:03:28 +0000 Received: from tees.elsevier.co.uk (tees.elsevier.co.uk [193.131.197.60]) by cadair.elsevier.co.uk (8.8.3/8.8.3) with ESMTP id RAA00563; Fri, 3 Jan 1997 17:03:24 GMT Received: (from dpr@localhost) by tees.elsevier.co.uk (8.8.3/8.8.3) id RAA02026; Fri, 3 Jan 1997 17:01:57 GMT To: Peter Wemm Cc: "Jordan K. Hubbard" , joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch), jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c References: <199701031610.AAA25840@spinner.DIALix.COM> From: Paul Richards Date: 03 Jan 1997 17:01:56 +0000 In-Reply-To: Peter Wemm's message of Sat, 04 Jan 1997 00:10:17 +0800 Message-ID: <57ybeapu9n.fsf@tees.elsevier.co.uk> Lines: 33 X-Mailer: Gnus v5.3/Emacs 19.30 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Peter Wemm writes: > I've sent mail on this off list, but for what it's worth, in /etc/rc we > have: > > rm -f /var/run/log > echo ' syslogd.'; syslogd > > Apart from the possibility of bugs in the unlink() code (Bruce has > commented on it), the change Jordan made should be about the same as > moving the rm -f into syslogd itself. It shouldn't make any difference.. > (But then again, I've had a rough few weeks, I am probably missing > something obvious again) See my other mail, it is dangerous for syslogd to simply do an unlink or even an `rm -f` since LogName can be passed from the command line and could be anything. The way it was before Jordan made his changes was correct in that it was safer than the previous behaviour of doing a blind unlink and yet still cleaned things up explicitly when appropriate. > I'm also not sure why it was possible for savecore to do a send() to the > /dev/log unix domain socket before anything had bound to it and started > listening for datagrams on it. Is this a special feature of AF_UNIX > sockets? Nor me. -- Paul Richards. Originative Solutions Ltd. (Netcraft Ltd. contractor) Elsevier Science TIS online journal project. Email: p.richards@elsevier.co.uk Phone: 0370 462071 (Mobile), +44 (0)1865 843155