From owner-dev-commits-src-all@freebsd.org Fri Mar 5 20:05:20 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE72E565DB4; Fri, 5 Mar 2021 20:05:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dsdy86T3kz3QGN; Fri, 5 Mar 2021 20:05:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id CBB3DBD89; Fri, 5 Mar 2021 20:05:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f180.google.com with SMTP id v64so2744680qtd.5; Fri, 05 Mar 2021 12:05:20 -0800 (PST) X-Gm-Message-State: AOAM532i/zfAYe80enLCtEs580lgzvUHHJCN0wL2iXNqbXeuO81TF3xb N3XslEYAMZiSqYeMGW+K6Xw23aYJGSAtK08gBqs= X-Google-Smtp-Source: ABdhPJxEEG/IGCi4jDFr+wdp/ozPyzcOzFYGHNOVJNbSlsQSDDn0kRBatzyML6zE2Z/LIqw92paHP6kJU6VS3UdH74M= X-Received: by 2002:ac8:5bd1:: with SMTP id b17mr10561631qtb.53.1614974720454; Fri, 05 Mar 2021 12:05:20 -0800 (PST) MIME-Version: 1.0 References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> In-Reply-To: <202103051755.125HtZsc073704@gitrepo.freebsd.org> From: Kyle Evans Date: Fri, 5 Mar 2021 14:05:06 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. To: John Baldwin Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 20:05:21 -0000 On Fri, Mar 5, 2021 at 11:55 AM John Baldwin wrote: > > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff > > commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff > Author: John Baldwin > AuthorDate: 2021-03-05 17:47:58 +0000 > Commit: John Baldwin > CommitDate: 2021-03-05 17:55:11 +0000 > > poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. > > There currently isn't a need to provide a public interface to a > software Poly1305 implementation beyond what is already available via > libsodium's APIs and these symbols conflict with symbols shared within > the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c. > > Reported by: se, kp > Fixes: 78991a93eb9d > Sponsored by: Netflix > --- > sys/opencrypto/xform_poly1305.c | 43 ++++++++++++----------------------------- > sys/opencrypto/xform_poly1305.h | 16 --------------- > 2 files changed, 12 insertions(+), 47 deletions(-) xform_poly1305.h also needs to stop being grouped in ^/include/Makefile (reported by jenkins via np)