From owner-svn-src-head@freebsd.org Mon Sep 2 15:26:37 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 872D6E1029; Mon, 2 Sep 2019 15:26:37 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46MYpP2v50z3Ppg; Mon, 2 Sep 2019 15:26:37 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd35.google.com with SMTP id d25so27275236iob.6; Mon, 02 Sep 2019 08:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8H+kZScnWOU/ZvH7QyUteeQwIXGVCdw5BDBM4OAEiok=; b=iLabulUcScbbFQ1XVfp8DciXPB+QiEK36wsl+Lh6f3fw/jKIPT/YADRLCgXDANNN2T 88lRYlgXN9cpaHJe6TjI1O11qhlBfdRBTbBQ849e5S5BvsND/cKKFkgW0R/CLW7U4Y9X T/l3aOMWiGP4VEwm9jk1aUHaykTJBLBmqx1Tt0SweASSqnUH1WFaXLoZuiDanvCjyQg1 PtqmdZ7g2H0mm8zjPdDKfuOT/K8aV9haOVZoAJSeIy9z0aN64NkPjZsQQ4R6HNPGbDSN M7KBmZeAQK0JAtw47EA1MASxWHzIuoWoVrsZAEZgmGg886yJKTvVNCw+rIMU4dEbkhaJ Jqog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=8H+kZScnWOU/ZvH7QyUteeQwIXGVCdw5BDBM4OAEiok=; b=VoLDb0nUGiipSpiPxR1VrRiVCQDlhRuO5/uZFhvwFg2k9VTe3IkotlqFmlqsxRSqkF 6pVfin/4LPV6Mfobur1ldbdrN+kLnGvrG45QArY0GU2C8cc8lPVvj6R6d85a3ewif3aS +MHdfWUHZe2PJLC98TvYEpPSVqjvyfAwxYFaJGm7BVwP84/CLeR6P1P8oNNV+xWGq6ip wN4pDjFDULXMeQ8hjCjZvsV1BT6tFMpWPr375qAqlarX92VRZCdojIGo8Dp/94kd0DmJ 1DMN6chKzRaURP7PEOA4Rm6kGdvRPzPhBToTzYMWNhycrU6vU9NhZM7P3bTNnz3lSvvB QzEQ== X-Gm-Message-State: APjAAAW0px4RFbsG4mwiB/l0uxioHGbL8NnbKfb4xmIoZeLoqNyyim07 H28oHT8Z7wsTzHUFdn18+k/Lk4v/ X-Google-Smtp-Source: APXvYqyeNsOjXL4kYy/1+FI5U3Gf4bWtgMbmCIX0zFR2gjzRlNfTryJA5yP/edSSLgYDHCMcIaG5ng== X-Received: by 2002:a5d:980d:: with SMTP id a13mr19868918iol.240.1567437995826; Mon, 02 Sep 2019 08:26:35 -0700 (PDT) Received: from raichu (toroon0560w-lp140-03-184-148-66-213.dsl.bell.ca. [184.148.66.213]) by smtp.gmail.com with ESMTPSA id i62sm5162940ioa.4.2019.09.02.08.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2019 08:26:35 -0700 (PDT) Sender: Mark Johnston Date: Mon, 2 Sep 2019 11:26:33 -0400 From: Mark Johnston To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351702 - head/sys/kern Message-ID: <20190902152633.GE68323@raichu> References: <201909021524.x82FOQZO033532@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201909021524.x82FOQZO033532@repo.freebsd.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46MYpP2v50z3Ppg X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.969,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2019 15:26:37 -0000 On Mon, Sep 02, 2019 at 03:24:26PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Mon Sep 2 15:24:25 2019 > New Revision: 351702 > URL: https://svnweb.freebsd.org/changeset/base/351702 > > Log: > vfs: restore mp null check in vop_stdgetwritemount > > The initially read mount point can already be NULL. > > Reported by: markj Just a correction: it was Peter that found the bug, not me. > Fixes: r351656 ("vfs: stop refing freed mount points in vop_stdgetwritemount") > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/kern/vfs_default.c > > Modified: head/sys/kern/vfs_default.c > ============================================================================== > --- head/sys/kern/vfs_default.c Mon Sep 2 14:51:59 2019 (r351701) > +++ head/sys/kern/vfs_default.c Mon Sep 2 15:24:25 2019 (r351702) > @@ -601,6 +601,8 @@ vop_stdgetwritemount(ap) > */ > vp = ap->a_vp; > mp = vp->v_mount; > + if (mp == NULL) > + goto out; > MNT_ILOCK(mp); > if (mp != vp->v_mount) { > MNT_IUNLOCK(mp); >