From owner-svn-src-all@freebsd.org Wed Mar 8 17:37:41 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00680D03A5B; Wed, 8 Mar 2017 17:37:41 +0000 (UTC) (envelope-from rizzo.unipi@gmail.com) Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C53941C1D; Wed, 8 Mar 2017 17:37:40 +0000 (UTC) (envelope-from rizzo.unipi@gmail.com) Received: by mail-it0-x232.google.com with SMTP id m27so49043269iti.0; Wed, 08 Mar 2017 09:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Kd40Ksy1k9IMMWaj8flYUGGwLiwVmaeyioVUst7BEfE=; b=CYBiynh6ImhCw7fHEZZyKY7AuVpjLi0SEdx3uBKLjxyodxehk0Zso7A59sIgldhh3K NGldu+1iiXsjVByHKqu3Ef5rlxGBrxfnDQOIt22rlL1sreBw2eZwq7Ke+3a3Qt4xLRaS KB3eJhHUfeRHccFuVCVpMGRURXDCp2/BXpDeN2I6GE4ep5uBboI9xAreq2DbhZkwHxt9 iZnDCprkdcSrBPzcEH3aygpUKrY5+vnRycrh6F2Kko/ZUUMU0I3l+kj0M8yCmUSZ11Xk BLNFHmFmHf9Zc+J/iKsFqY3PdxTTBfmDV3pUwogi3G13Aq/W8TMTQgVD01hEhLu7dIfi 4x8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Kd40Ksy1k9IMMWaj8flYUGGwLiwVmaeyioVUst7BEfE=; b=fJIZ0vvojQMGcRts5MWNnF/YRQH1sMeIk5rT6k2RmKENLE2V6tK2daUuAJj9Tdbw8z 8ZuLOS+Z1Dle4GL6WC+55wjjnBO4zlldCv5cD9chzH8TIzFZCA1QtkOD4d2bQy975n3E 2/cAiFL0Z+EecoIec1RyHsdXLhUu4odqcFHWV7YbEy61x5b6sma1XDBlxuJjc8QZ//i8 bJxdN+cz65+ZfLIbQElbrcrEbWmvy3h53DpeSz5ZCeU7nSG+m8irD38p0sY2lD1eXHDt 1RHeNqvwhyKLgo9MeV+5iVX8iuObzCyOHUviY+M2BPMIKmAl9Nqc32JdTz3OUxzncfit +YaQ== X-Gm-Message-State: AMke39mzn1PnLOqqmtP+1xMAdXVO1C5dhR65Pl25zqU804WBS29oyM/vIyr0cEzIi82fdIQCEgblAXq6KIHzwQ== X-Received: by 10.36.65.105 with SMTP id x102mr7273797ita.32.1488994658025; Wed, 08 Mar 2017 09:37:38 -0800 (PST) MIME-Version: 1.0 Sender: rizzo.unipi@gmail.com Received: by 10.107.139.203 with HTTP; Wed, 8 Mar 2017 09:37:37 -0800 (PST) In-Reply-To: <201703081729.v28HTekF062971@repo.freebsd.org> References: <201703081729.v28HTekF062971@repo.freebsd.org> From: Luigi Rizzo Date: Wed, 8 Mar 2017 09:37:37 -0800 X-Google-Sender-Auth: dPEannZRtQu3FsmhOe_m-hlUIK4 Message-ID: Subject: Re: svn commit: r314915 - head/tools/tools/netmap To: Sean Bruno Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 17:37:41 -0000 On Wed, Mar 8, 2017 at 9:29 AM, Sean Bruno wrote: > Author: sbruno > Date: Wed Mar 8 17:29:40 2017 > New Revision: 314915 > URL: https://svnweb.freebsd.org/changeset/base/314915 > > Log: > Use the buildworld includes and defaults when building pkt-gen. This will > mean that you need a world built to reliably build pkg-gen but this keeps > the build from failing when your source doesn't match your host running > version, e.g. building 12 on 11. This is a good change, but maybe it could help to leave a comment like the following one in the Makefile: # Some netmap helper functions are in sys/net/netmap_user.h. # To build applications using the headers in the source tree, use # make CFLAGS="-nostdinc -I ../../../sys -I/usr/include" ... This is because netmap does not have a proper support library, but some minimal helper functions in netmap_user.h , and people may want to override them. cheers luigi > > Submitted by: Matt Macy > MFC after: 2 weeks > Sponsored by: Limelight Networks > > Modified: > head/tools/tools/netmap/Makefile > > Modified: head/tools/tools/netmap/Makefile > ============================================================================== > --- head/tools/tools/netmap/Makefile Wed Mar 8 14:52:03 2017 (r314914) > +++ head/tools/tools/netmap/Makefile Wed Mar 8 17:29:40 2017 (r314915) > @@ -8,7 +8,6 @@ PROGS = pkt-gen nmreplay bridge vale-ctl > CLEANFILES = $(PROGS) *.o > MAN= > CFLAGS += -Werror -Wall > -CFLAGS += -nostdinc -I ../../../sys -I/usr/include > CFLAGS += -Wextra > > LDFLAGS += -lpthread > -- -----------------------------------------+------------------------------- Prof. Luigi RIZZO, rizzo@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL +39-050-2217533 . via Diotisalvi 2 Mobile +39-338-6809875 . 56122 PISA (Italy) -----------------------------------------+-------------------------------