From owner-svn-src-all@freebsd.org Fri Oct 23 00:21:28 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3626A1C679; Fri, 23 Oct 2015 00:21:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id CF4D0C83; Fri, 23 Oct 2015 00:21:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id C9559198F; Fri, 23 Oct 2015 00:21:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 8C26C121A0; Fri, 23 Oct 2015 00:21:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id wXNfhjuDJkvq; Fri, 23 Oct 2015 00:21:25 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 817B41219C Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r289778 - head/share/mk From: Bryan Drewery X-Mailer: iPhone Mail (12H143) In-Reply-To: <232D9171-D360-4110-8682-6B371D9F9CAC@FreeBSD.org> Date: Thu, 22 Oct 2015 17:21:24 -0700 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6847681E-3E85-40B9-BF9D-2FF4C6DE4AC9@FreeBSD.org> References: <201510222341.t9MNfuNK007465@repo.freebsd.org> <1445558386.14963.38.camel@freebsd.org> <232D9171-D360-4110-8682-6B371D9F9CAC@FreeBSD.org> To: Ian Lepore X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 00:21:29 -0000 > On Oct 22, 2015, at 17:18, Bryan Drewery wrote: >=20 >=20 >=20 >>> On Oct 22, 2015, at 16:59, Ian Lepore wrote: >>>=20 >>> On Thu, 2015-10-22 at 23:41 +0000, Bryan Drewery wrote: >>> Author: bdrewery >>> Date: Thu Oct 22 23:41:56 2015 >>> New Revision: 289778 >>> URL: https://svnweb.freebsd.org/changeset/base/289778 >>>=20 >>> Log: >>> For SUBDIR_PARALLEL, when doing 'make clean*' or 'make obj' there >>> is no need to >>> respect SUBDIR_DEPEND_* or .WAIT. >>>=20 >>> MFC after: 2 weeks >>> Sponsored by: EMC / Isilon Storage Division >>=20 >> This doesn't feel so safe. People override these targets and do who >> -knows-what with them. The clean* seems especially risky since it will >> match targets in end-user makefiles that you don't even know about. I can also not apply to SUBDIR_TARGETS which is the user-defined targets lis= t. (Misspelled and should be LOCAL_SUBDIR_TARGETS) >>=20 >> -- Ian >=20 > I can limit it to src tree builds if you want. >=20 > I cannot imagine any situation where "clean" depends on another= directory going first.=20 >=20 > Similarly it makes sense to always build subdirs in parallel with 'obj' an= d I would argue 'clean*' too, regardless of SUBDIR_PARALLEL. I only just rea= lized that. Yes there are mkdir -p and rm -f races, but we have not added an= y dependencies because of these as is.